Page MenuHomePhabricator

[MergeICmps] Make base ordering really deterministic.
ClosedPublic

Authored by courbet on Feb 15 2019, 1:21 AM.

Details

Summary

The idea is that we now manipulate bases through a unsigned BaseID based on
order of appearance in the comparison chain rather than through the Value*.

Fixes 40714.

Diff Detail

Repository
rL LLVM

Event Timeline

courbet created this revision.Feb 15 2019, 1:21 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 15 2019, 1:21 AM
courbet updated this revision to Diff 186978.Feb 15 2019, 1:57 AM

use dense_map instead of unordered_map

gchatelet added inline comments.Feb 15 2019, 2:11 AM
lib/Transforms/Scalar/MergeICmps.cpp
87 ↗(On Diff #186974)

Remove.

96 ↗(On Diff #186974)

Remove

106 ↗(On Diff #186974)

You may keep {} for consistency with BCECmpBlock below.

courbet updated this revision to Diff 186996.Feb 15 2019, 4:53 AM
courbet marked 2 inline comments as done.

use {} instead of BCEAtom().

gchatelet accepted this revision.Feb 15 2019, 5:03 AM
This revision is now accepted and ready to land.Feb 15 2019, 5:03 AM
This revision was automatically updated to reflect the committed changes.