[lldb] [MainLoop] Remove redundant termination clause (NFCI)

[mgorny]

Summary

Remove the redundant termination clause from within the loop. Since
the check is done at the end of the loop, it's entirely redundant
to the 'while' condition. If termination was requested, the latter
will become false and the 'while' loop will terminate, resulting
in the 'return' statement below the loop being executed (which is
equivalent to the one used inside 'if').

[krytarowski]

It looks good to me.

[labath]

That sounds correct. The extra check must have crept in because of all the refactors this class has gone through to support all possible event handling mechanisms...

lldb/source/Host/common/MainLoop.cpp

Status MainLoop::Run() {
   // run until termination or until we run out of things to listen to
   while (!m_terminate_request && (!m_read_fds.empty() || !m_signals.empty())) {
 
     error = impl.Poll();
     if (error.Fail())
       return error;
 
     impl.ProcessEvents();
-
-    if (m_terminate_request)
-      return Status();
   }
   return Status();
 }
 
 void MainLoop::ProcessSignal(int signo) {
   auto it = m_signals.find(signo);
   if (it != m_signals.end())
     it->second.callback(*this); // Do the work
 }
 
 void MainLoop::ProcessReadObject(IOObject::WaitableHandle handle) {
   auto it = m_read_fds.find(handle);
   if (it != m_read_fds.end())
     it->second(*this); // Do the work
 }