Page MenuHomePhabricator

[CMake] Don't override required compiler flags in the runtimes build
ClosedPublic

Authored by phosek on Feb 11 2019, 5:52 PM.

Details

Summary

Ensure that HandleLLVMOptions adds all necessary required flags,
including -Wno-error when building with LLVM_ENABLE_WERROR enabled.

Diff Detail

Repository
rL LLVM

Event Timeline

phosek created this revision.Feb 11 2019, 5:52 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 11 2019, 5:52 PM

This is a better alternative to D57142. After this change lands, runtimes build should be working with LLVM_ENABLE_WERROR.

smeenai accepted this revision.Feb 11 2019, 6:06 PM

LGTM

llvm/runtimes/CMakeLists.txt
105

Does DetermineGCCCompatible not do the right thing already?

This revision is now accepted and ready to land.Feb 11 2019, 6:06 PM
phosek updated this revision to Diff 186383.Feb 11 2019, 6:10 PM
phosek marked an inline comment as done.
This revision was automatically updated to reflect the committed changes.