Add missing library dependencies in CMakeLists.txt

[comex]

Summary

Fixes build in BUILD_SHARED_LIBS mode.

Removes the "DEPENDS clangdXpcJsonConversions" line as LINK_LIBS already implies a dependency AFAIK.

[phosek]

LGTM

[comex]

Oh, forgot to mention in the initial submission: I don't have commit access so I'll need someone else to commit this.

[comex]

Ping.

[jkorous]

Hi @comex, I totally missed this! Thanks for the patch.
I am not entirely happy about this dependency though. I am trying to split off the only parts of clangDaemon that XpcTransport actually uses.
I'll either put up my patch for review tomorrow or commit your solution.

[jkorous]

Reconsidered - let's fix the build first and I can finish my patch tomorrow.

clangd/xpc/CMakeLists.txt

set(LLVM_LINK_COMPONENTS
   Support
   )
 
 # Needed by LLVM's CMake checks because this file defines multiple targets.
 set(LLVM_OPTIONAL_SOURCES Conversion.cpp XPCTransport.cpp)
 
 add_clang_library(clangdXpcJsonConversions
   Conversion.cpp
+  LINK_LIBS clangDaemon
   )
 
 add_clang_library(clangdXpcTransport
   XPCTransport.cpp
-  DEPENDS clangdXpcJsonConversions
-  LINK_LIBS clangdXpcJsonConversions
+  LINK_LIBS clangDaemon clangdXpcJsonConversions
   )