Page MenuHomePhabricator

comex (Nicholas Allegra)Email Not Verified
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 7 2015, 10:13 PM (198 w, 4 h)

Recent Activity

May 13 2019

comex updated the diff for D61417: [NFC] Refactor TargetCallingConv so calling conventions can see which parameters are varargs.

Thanks for the feedback, updated.

May 13 2019, 3:09 PM · Restricted Project

May 8 2019

comex added a comment to D61714: [MachO] Fix two bugs with reexported dylibs.

Oops, forgot to mention:

May 8 2019, 7:36 PM · Restricted Project
comex created D61714: [MachO] Fix two bugs with reexported dylibs.
May 8 2019, 7:32 PM · Restricted Project

May 1 2019

comex created D61417: [NFC] Refactor TargetCallingConv so calling conventions can see which parameters are varargs.
May 1 2019, 6:12 PM · Restricted Project

Apr 16 2019

comex added a comment to D58083: lld: Fix initial Mach-O load commands size calculation omitting LC_FUNCTION_STARTS.

Thanks for the review. I don't have commit access.

Apr 16 2019, 4:50 PM · Restricted Project

Mar 25 2019

comex added a comment to D58083: lld: Fix initial Mach-O load commands size calculation omitting LC_FUNCTION_STARTS.

Second ping.

Mar 25 2019, 8:58 PM · Restricted Project

Feb 25 2019

comex added a comment to D58089: Add missing library dependencies in CMakeLists.txt.

Ping.

Feb 25 2019, 2:02 PM · Restricted Project

Feb 12 2019

comex added a comment to D58089: Add missing library dependencies in CMakeLists.txt.

Oh, forgot to mention in the initial submission: I don't have commit access so I'll need someone else to commit this.

Feb 12 2019, 4:24 PM · Restricted Project

Feb 11 2019

comex created D58089: Add missing library dependencies in CMakeLists.txt.
Feb 11 2019, 4:43 PM · Restricted Project
comex created D58083: lld: Fix initial Mach-O load commands size calculation omitting LC_FUNCTION_STARTS.
Feb 11 2019, 4:10 PM · Restricted Project

Jul 2 2018

comex updated the diff for D48811: Fix disassembling ARM instructions as big-endian.

Fix disassembling ARM instructions as big-endian

Jul 2 2018, 12:24 PM

Jul 1 2018

comex created D48811: Fix disassembling ARM instructions as big-endian.
Jul 1 2018, 3:26 PM

Mar 11 2018

comex created D44373: Fix reading objects created with -fembed-bitcode-marker..
Mar 11 2018, 4:30 PM · Restricted Project

Jan 21 2018

comex updated the diff for D40826: [LLD] Use Rela on PowerPC too.

Sorry for the delay; here's an updated diff with a test. (The test didn't seem to clearly belong in any existing .s file I saw, so I just made a new one.)

Jan 21 2018, 12:08 AM

Dec 4 2017

comex created D40826: [LLD] Use Rela on PowerPC too.
Dec 4 2017, 9:50 PM

Jan 13 2016

comex added reviewers for D15907: Allow various function attributes to be specified on Objective-C blocks too.: aaron.ballman, rsmith.

Ping, and adding potential reviewers like I was supposed to do in the first place.

Jan 13 2016, 12:24 PM

Jan 5 2016

comex retitled D15907: Allow various function attributes to be specified on Objective-C blocks too. from to Allow various function attributes to be specified on Objective-C blocks too..
Jan 5 2016, 3:08 PM

Dec 9 2015

comex retitled D15406: Add warning for attribute-cleanup on function parameter. from to Add warning for attribute-cleanup on function parameter..
Dec 9 2015, 10:33 PM

Nov 10 2015

comex added a comment to D12686: Add support for GCC's '__auto_type' extension..

I don't have SVN access. If you want to commit it, feel free to remove that comment, or else I'll update the diff tomorrow.

Nov 10 2015, 3:06 PM
comex added a comment to D12686: Add support for GCC's '__auto_type' extension..

Addressed comments. Thanks, rsmith!

Nov 10 2015, 11:27 AM
comex updated the diff for D12686: Add support for GCC's '__auto_type' extension..
Nov 10 2015, 11:25 AM

Nov 5 2015

comex added a comment to D12686: Add support for GCC's '__auto_type' extension..

(Ping? I verified yesterday that the patch still applies and passes regression tests.)

Nov 5 2015, 5:09 AM

Oct 21 2015

comex added a comment to D12686: Add support for GCC's '__auto_type' extension..

One more ping. As far as I know, everything has been addressed.

Oct 21 2015, 2:56 PM

Oct 13 2015

comex added inline comments to D12686: Add support for GCC's '__auto_type' extension..
Oct 13 2015, 12:14 PM
comex added inline comments to D12686: Add support for GCC's '__auto_type' extension..
Oct 13 2015, 1:12 AM
comex added inline comments to D12686: Add support for GCC's '__auto_type' extension..
Oct 13 2015, 1:10 AM

Oct 12 2015

comex updated the diff for D12686: Add support for GCC's '__auto_type' extension..

Okay.

Oct 12 2015, 10:09 PM
comex updated the diff for D12686: Add support for GCC's '__auto_type' extension..

Fixed raised issues.

Oct 12 2015, 5:46 PM
comex added inline comments to D12686: Add support for GCC's '__auto_type' extension..
Oct 12 2015, 5:27 PM
comex added a comment to D12686: Add support for GCC's '__auto_type' extension..

Ping again.

Oct 12 2015, 1:16 AM

Sep 26 2015

comex added a comment to D12686: Add support for GCC's '__auto_type' extension..

Ping?

Sep 26 2015, 9:11 PM

Sep 14 2015

comex updated the diff for D12686: Add support for GCC's '__auto_type' extension..

Per vsk:

  • Changed to an explicit switch, and changed ContainsPlaceholderType logic.
Sep 14 2015, 11:55 PM

Sep 8 2015

comex retitled D12686: Add support for GCC's '__auto_type' extension. from to Add support for GCC's '__auto_type' extension..
Sep 8 2015, 12:44 AM