- User Since
- Sep 7 2015, 10:13 PM (280 w, 1 d)
Aug 26 2020
Disabling the thread list while the target is running sounds like a pretty complex change. For example, what should happen if a Python script calls lldb.process.GetThreadAtIndex(n) while the target is running, which currently works?
Aug 25 2020
The sequence I found is:
- DoResume sends eBroadcastBitAsyncContinue to ProcessGDBRemote::AsyncThread
- AsyncThread calls process->SetPrivateState(eStateRunning);
- …which sends eBroadcastBitStateChanged back to the main thread, handled by Process::HandlePrivateEvent
- …which ends up in this stack, when it tries to figure out whether to report the state change to the user:
- Process::HandlePrivateEvent ->
- Process::ShouldBroadcastEvent ->
- ThreadList::ShouldReportRun ->
- Thread::ShouldReportRun ->
- ThreadPlan::ShouldReportRun ->
- ThreadPlan::GetPreviousPlan ->
Aug 21 2020
Feb 16 2020
Oct 17 2019
So, I landed this patch but had to revert it as it broke the build on MSVC (and only MSVC). That was almost a month ago, but I haven't gotten back around to this until now – sorry :|
Sep 26 2019
Sep 19 2019
Sep 18 2019
Fixed a mistake where the diagnostic would print the wrong parameter type.
Here's a new version of the patch that uses iterator ranges instead of ArrayRef, to avoid adding new uses of CallExpr::getArgs() in case it has to be removed in the future due to the strict aliasing issue.
Sep 17 2019
Ugh, it looks like getArgs() is a massive strict aliasing violation. And it's used in enough different places in Clang that fixing the violation may require extensive refactoring... I've reported the issue as https://bugs.llvm.org/show_bug.cgi?id=43344, but I don't really want to fix it :)
Sep 16 2019
Sounds good; I'll split this into a few separate patches.
Ping. I'm not qualified to review this myself but I'd like to see the bug fixed. :)
Aug 27 2019
Aug 26 2019
Heh, I guess I'll request commit access, although I'm not sure if I have enough of a 'track record of submitting high quality patches'. But for now, can you commit this? Thanks :)
Addressed review comments.
Aug 21 2019
Changes since last version:
Aug 18 2019
Aug 11 2019
Oops, I forgot to re-run git diff after fixing the patch.
May 13 2019
Thanks for the feedback, updated.
May 8 2019
Oops, forgot to mention:
May 1 2019
Apr 16 2019
Thanks for the review. I don't have commit access.
Mar 25 2019
Feb 25 2019
Feb 12 2019
Oh, forgot to mention in the initial submission: I don't have commit access so I'll need someone else to commit this.
Feb 11 2019
Jul 2 2018
Fix disassembling ARM instructions as big-endian
Jul 1 2018
Mar 11 2018
Jan 21 2018
Sorry for the delay; here's an updated diff with a test. (The test didn't seem to clearly belong in any existing .s file I saw, so I just made a new one.)
Dec 4 2017
Jan 13 2016
Ping, and adding potential reviewers like I was supposed to do in the first place.
Jan 5 2016
Dec 9 2015
Nov 10 2015
I don't have SVN access. If you want to commit it, feel free to remove that comment, or else I'll update the diff tomorrow.
Addressed comments. Thanks, rsmith!
Nov 5 2015
(Ping? I verified yesterday that the patch still applies and passes regression tests.)
Oct 21 2015
One more ping. As far as I know, everything has been addressed.
Oct 13 2015
Oct 12 2015
Fixed raised issues.
Sep 26 2015
Sep 14 2015
- Changed to an explicit switch, and changed ContainsPlaceholderType logic.