Page MenuHomePhabricator

comex (Nicholas Allegra)Email Not Verified
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 7 2015, 10:13 PM (210 w, 4 d)

Recent Activity

Thu, Sep 19

comex updated the diff for D67647: [Consumed] Refactor handleCall to take function argument list. NFC..

Right - I was suggesting that could be changed. Would it be OK to you to change arguments() to return ArrayRef? Or would you rather avoid that to avoid baking in more dependence on that alias violation?

Thu, Sep 19, 5:42 PM · Restricted Project, Restricted Project
comex created D67778: [Consumed] Narrow Subject for some attributes.
Thu, Sep 19, 4:54 PM · Restricted Project
comex updated the diff for D67740: [Consumed] Refactor and improve diagnostics.

Addressed feedback.

Thu, Sep 19, 4:34 PM · Restricted Project
comex added a comment to D67740: [Consumed] Refactor and improve diagnostics.

Looks like this might benefit from being split into independent changes - the work related to templates (I haven't looked closely, but I assume that's fairly indivisible) and the work related to other diagnostics seems fairly separable - and maybe there's other pieces too.

Thu, Sep 19, 4:34 PM · Restricted Project
comex committed rG9dd57df26abf: [Consumed] Treat by-value class arguments as consuming by default, like rvalue… (authored by comex).
[Consumed] Treat by-value class arguments as consuming by default, like rvalue…
Thu, Sep 19, 4:02 PM
comex committed rL372361: [Consumed] Treat by-value class arguments as consuming by default, like rvalue….
[Consumed] Treat by-value class arguments as consuming by default, like rvalue…
Thu, Sep 19, 4:02 PM
comex closed D67743: [Consumed] Treat by-value class arguments as consuming by default, like rvalue refs..
Thu, Sep 19, 4:02 PM · Restricted Project, Restricted Project
comex added a comment to D67743: [Consumed] Treat by-value class arguments as consuming by default, like rvalue refs..

"Also, fix the order of if statements so that an explicit return_typestate annotation takes precedence over the default behavior for rvalue refs."

I'd probably have split that out into a separate patch - in part to discuss the design implications of that. I have some doubts about supporting non-consumed after passing by rvalue ref, but don't feel too strongly & the alternative would be having a warning about the attribute being ignored, etc - when it has a fairly clear meaning if it is there, just not sure people 'should' be doing that.

Thu, Sep 19, 3:57 PM · Restricted Project, Restricted Project

Wed, Sep 18

comex updated the diff for D67740: [Consumed] Refactor and improve diagnostics.

Fixed a mistake where the diagnostic would print the wrong parameter type.

Wed, Sep 18, 6:18 PM · Restricted Project
comex added a comment to D67647: [Consumed] Refactor handleCall to take function argument list. NFC..

I wasn't expecting it to involve all this work - but instead to change "arguments()" to return ArrayRef. Though perhaps you didn't go that route to allow future fixes to the strict aliasing (by having an adapting iterator - or perhaps arguments() already uses such an iterator that doesn't hit the strict aliasing issue?) needing to do even more cleaunp work?

Wed, Sep 18, 6:05 PM · Restricted Project, Restricted Project
comex created D67743: [Consumed] Treat by-value class arguments as consuming by default, like rvalue refs..
Wed, Sep 18, 5:35 PM · Restricted Project, Restricted Project
comex updated the diff for D67647: [Consumed] Refactor handleCall to take function argument list. NFC..

Here's a new version of the patch that uses iterator ranges instead of ArrayRef, to avoid adding new uses of CallExpr::getArgs() in case it has to be removed in the future due to the strict aliasing issue.

Wed, Sep 18, 5:22 PM · Restricted Project, Restricted Project
comex created D67740: [Consumed] Refactor and improve diagnostics.
Wed, Sep 18, 4:31 PM · Restricted Project

Tue, Sep 17

comex added a comment to D67647: [Consumed] Refactor handleCall to take function argument list. NFC..

Ugh, it looks like getArgs() is a massive strict aliasing violation. And it's used in enough different places in Clang that fixing the violation may require extensive refactoring... I've reported the issue as https://bugs.llvm.org/show_bug.cgi?id=43344, but I don't really want to fix it :)

Tue, Sep 17, 5:42 PM · Restricted Project, Restricted Project

Mon, Sep 16

comex created D67647: [Consumed] Refactor handleCall to take function argument list. NFC..
Mon, Sep 16, 8:05 PM · Restricted Project, Restricted Project
comex abandoned D66830: Consumed checker: various improvements.

Sounds good; I'll split this into a few separate patches.

Mon, Sep 16, 6:58 PM · Restricted Project
comex committed rGcbd13bc1edfe: Push lambda scope earlier when transforming lambda expression (authored by comex).
Push lambda scope earlier when transforming lambda expression
Mon, Sep 16, 6:43 PM
comex committed rL372058: Push lambda scope earlier when transforming lambda expression.
Push lambda scope earlier when transforming lambda expression
Mon, Sep 16, 6:42 PM
comex closed D66067: Push lambda scope earlier when transforming lambda expression.
Mon, Sep 16, 6:42 PM · Restricted Project, Restricted Project
comex added a comment to D65694: Properly instantiate a decltype in argument's default initializer.

Ping. I'm not qualified to review this myself but I'd like to see the bug fixed. :)

Mon, Sep 16, 5:13 PM · Restricted Project

Tue, Aug 27

comex added a comment to D65694: Properly instantiate a decltype in argument's default initializer.

Ping.

Tue, Aug 27, 2:36 PM · Restricted Project
comex created D66830: Consumed checker: various improvements.
Tue, Aug 27, 2:35 PM · Restricted Project

Mon, Aug 26

comex added a comment to D66404: [CFG] Make destructor calls more accurate.

Heh, I guess I'll request commit access, although I'm not sure if I have enough of a 'track record of submitting high quality patches'. But for now, can you commit this? Thanks :)

Mon, Aug 26, 1:48 PM · Restricted Project, Restricted Project
comex added inline comments to D66067: Push lambda scope earlier when transforming lambda expression.
Mon, Aug 26, 1:31 PM · Restricted Project, Restricted Project
comex updated the diff for D66067: Push lambda scope earlier when transforming lambda expression.

Addressed review comments.

Mon, Aug 26, 1:31 PM · Restricted Project, Restricted Project

Aug 21 2019

comex updated the diff for D66404: [CFG] Make destructor calls more accurate.

Changes since last version:

Aug 21 2019, 8:17 PM · Restricted Project, Restricted Project
comex abandoned D66404: [CFG] Make destructor calls more accurate.
Aug 21 2019, 8:09 PM · Restricted Project, Restricted Project

Aug 18 2019

comex created D66404: [CFG] Make destructor calls more accurate.
Aug 18 2019, 4:16 PM · Restricted Project, Restricted Project
comex added inline comments to D66067: Push lambda scope earlier when transforming lambda expression.
Aug 18 2019, 3:03 PM · Restricted Project, Restricted Project

Aug 11 2019

comex updated the diff for D66067: Push lambda scope earlier when transforming lambda expression.

Oops, I forgot to re-run git diff after fixing the patch.

Aug 11 2019, 8:30 PM · Restricted Project, Restricted Project
comex created D66067: Push lambda scope earlier when transforming lambda expression.
Aug 11 2019, 8:26 PM · Restricted Project, Restricted Project

May 13 2019

comex updated the diff for D61417: [NFC] Refactor TargetCallingConv so calling conventions can see which parameters are varargs.

Thanks for the feedback, updated.

May 13 2019, 3:09 PM · Restricted Project

May 8 2019

comex added a comment to D61714: [MachO] Fix two bugs with reexported dylibs.

Oops, forgot to mention:

May 8 2019, 7:36 PM · Restricted Project
comex created D61714: [MachO] Fix two bugs with reexported dylibs.
May 8 2019, 7:32 PM · Restricted Project

May 1 2019

comex created D61417: [NFC] Refactor TargetCallingConv so calling conventions can see which parameters are varargs.
May 1 2019, 6:12 PM · Restricted Project

Apr 16 2019

comex added a comment to D58083: lld: Fix initial Mach-O load commands size calculation omitting LC_FUNCTION_STARTS.

Thanks for the review. I don't have commit access.

Apr 16 2019, 4:50 PM · Restricted Project

Mar 25 2019

comex added a comment to D58083: lld: Fix initial Mach-O load commands size calculation omitting LC_FUNCTION_STARTS.

Second ping.

Mar 25 2019, 8:58 PM · Restricted Project

Feb 25 2019

comex added a comment to D58089: Add missing library dependencies in CMakeLists.txt.

Ping.

Feb 25 2019, 2:02 PM · Restricted Project

Feb 12 2019

comex added a comment to D58089: Add missing library dependencies in CMakeLists.txt.

Oh, forgot to mention in the initial submission: I don't have commit access so I'll need someone else to commit this.

Feb 12 2019, 4:24 PM · Restricted Project

Feb 11 2019

comex created D58089: Add missing library dependencies in CMakeLists.txt.
Feb 11 2019, 4:43 PM · Restricted Project
comex created D58083: lld: Fix initial Mach-O load commands size calculation omitting LC_FUNCTION_STARTS.
Feb 11 2019, 4:10 PM · Restricted Project

Jul 2 2018

comex updated the diff for D48811: Fix disassembling ARM instructions as big-endian.

Fix disassembling ARM instructions as big-endian

Jul 2 2018, 12:24 PM

Jul 1 2018

comex created D48811: Fix disassembling ARM instructions as big-endian.
Jul 1 2018, 3:26 PM

Mar 11 2018

comex created D44373: Fix reading objects created with -fembed-bitcode-marker..
Mar 11 2018, 4:30 PM · Restricted Project

Jan 21 2018

comex updated the diff for D40826: [LLD] Use Rela on PowerPC too.

Sorry for the delay; here's an updated diff with a test. (The test didn't seem to clearly belong in any existing .s file I saw, so I just made a new one.)

Jan 21 2018, 12:08 AM

Dec 4 2017

comex created D40826: [LLD] Use Rela on PowerPC too.
Dec 4 2017, 9:50 PM

Jan 13 2016

comex added reviewers for D15907: Allow various function attributes to be specified on Objective-C blocks too.: aaron.ballman, rsmith.

Ping, and adding potential reviewers like I was supposed to do in the first place.

Jan 13 2016, 12:24 PM

Jan 5 2016

comex retitled D15907: Allow various function attributes to be specified on Objective-C blocks too. from to Allow various function attributes to be specified on Objective-C blocks too..
Jan 5 2016, 3:08 PM

Dec 9 2015

comex retitled D15406: Add warning for attribute-cleanup on function parameter. from to Add warning for attribute-cleanup on function parameter..
Dec 9 2015, 10:33 PM

Nov 10 2015

comex added a comment to D12686: Add support for GCC's '__auto_type' extension..

I don't have SVN access. If you want to commit it, feel free to remove that comment, or else I'll update the diff tomorrow.

Nov 10 2015, 3:06 PM
comex added a comment to D12686: Add support for GCC's '__auto_type' extension..

Addressed comments. Thanks, rsmith!

Nov 10 2015, 11:27 AM
comex updated the diff for D12686: Add support for GCC's '__auto_type' extension..
Nov 10 2015, 11:25 AM

Nov 5 2015

comex added a comment to D12686: Add support for GCC's '__auto_type' extension..

(Ping? I verified yesterday that the patch still applies and passes regression tests.)

Nov 5 2015, 5:09 AM

Oct 21 2015

comex added a comment to D12686: Add support for GCC's '__auto_type' extension..

One more ping. As far as I know, everything has been addressed.

Oct 21 2015, 2:56 PM

Oct 13 2015

comex added inline comments to D12686: Add support for GCC's '__auto_type' extension..
Oct 13 2015, 12:14 PM
comex added inline comments to D12686: Add support for GCC's '__auto_type' extension..
Oct 13 2015, 1:12 AM
comex added inline comments to D12686: Add support for GCC's '__auto_type' extension..
Oct 13 2015, 1:10 AM

Oct 12 2015

comex updated the diff for D12686: Add support for GCC's '__auto_type' extension..

Okay.

Oct 12 2015, 10:09 PM
comex updated the diff for D12686: Add support for GCC's '__auto_type' extension..

Fixed raised issues.

Oct 12 2015, 5:46 PM
comex added inline comments to D12686: Add support for GCC's '__auto_type' extension..
Oct 12 2015, 5:27 PM
comex added a comment to D12686: Add support for GCC's '__auto_type' extension..

Ping again.

Oct 12 2015, 1:16 AM

Sep 26 2015

comex added a comment to D12686: Add support for GCC's '__auto_type' extension..

Ping?

Sep 26 2015, 9:11 PM

Sep 14 2015

comex updated the diff for D12686: Add support for GCC's '__auto_type' extension..

Per vsk:

  • Changed to an explicit switch, and changed ContainsPlaceholderType logic.
Sep 14 2015, 11:55 PM

Sep 8 2015

comex retitled D12686: Add support for GCC's '__auto_type' extension. from to Add support for GCC's '__auto_type' extension..
Sep 8 2015, 12:44 AM