Page MenuHomePhabricator

Fix auto-upgrade for the new parameter to llvm.objectsize
ClosedPublic

Authored by erik.pilkington on Feb 11 2019, 1:14 PM.

Details

Summary

D56761 added a 'dynamic' parameter to objectsize, but the AutoUpgrade changes were incomplete. Also, fix an off-by-one error I made in the upgrade logic that is now no longer unreachable.

Thanks!

Diff Detail

Repository
rL LLVM

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptFeb 11 2019, 1:14 PM
vsk accepted this revision.Feb 11 2019, 1:18 PM

Thanks, lgtm. Steven?

This revision is now accepted and ready to land.Feb 11 2019, 1:18 PM

I talked to Erik offline. I think the upgrade tests should run on .bc file rather than text format.

Use a .bc file in the test. @steven_wu, LG?

This revision was automatically updated to reflect the committed changes.