This is an archive of the discontinued LLVM Phabricator instance.

[lldb] [lldb-instr] Add missing linkage to clang libraries
ClosedPublic

Authored by mgorny on Feb 9 2019, 5:59 AM.

Download Raw Diff

Details

Reviewers

JDevlieghere
labath

Commits

rGf68b6cbae27c: [lldb] [lldb-instr] Add missing linkage to clang libraries
rL353680: [lldb] [lldb-instr] Add missing linkage to clang libraries
rLLDB353680: [lldb] [lldb-instr] Add missing linkage to clang libraries

Summary

Fix build errors against shared clang by adding all the libraries used
in the code.

Diff Detail

Event Timeline

mgorny created this revision.Feb 9 2019, 5:59 AM

Herald added subscribers: teemperor, abidh. · View Herald TranscriptFeb 9 2019, 5:59 AM

Expecting more.

That's the complete set.

This happens when using the standalone build, right?

I suspect this happens only there because cmake does not have enough information to correctly include transitive deps automatically. That's slightly unfortunate, but I guess we can live with it.

This revision is now accepted and ready to land.Feb 11 2019, 1:42 AM

Yes, I'm using the standalone build. Thanks.

Closed by commit rLLDB353680: [lldb] [lldb-instr] Add missing linkage to clang libraries (authored by mgorny). · Explain WhyFeb 11 2019, 2:02 AM

This revision was automatically updated to reflect the committed changes.

Thanks!

Revision Contents

Path

Size

lldb/

tools/

lldb-instr/

CMakeLists.txt

3 lines

Diff 186111

lldb/tools/lldb-instr/CMakeLists.txt

	add_lldb_tool(lldb-instr			add_lldb_tool(lldb-instr
	Instrument.cpp			Instrument.cpp

	LINK_LIBS			LINK_LIBS
	clangAST			clangAST
	clangBasic			clangBasic
	clangFrontend			clangFrontend
				clangLex
				clangRewrite
				clangSerialization
	clangTooling			clangTooling

	LINK_COMPONENTS			LINK_COMPONENTS
	Support			Support
	)			)