Page MenuHomePhabricator

[lldb] [lldb-instr] Add missing linkage to clang libraries
ClosedPublic

Authored by mgorny on Feb 9 2019, 5:59 AM.

Diff Detail

Repository
rLLDB LLDB

Event Timeline

mgorny created this revision.Feb 9 2019, 5:59 AM
mgorny planned changes to this revision.Feb 9 2019, 6:02 AM

Expecting more.

mgorny updated this revision to Diff 186111.Feb 9 2019, 6:04 AM
mgorny retitled this revision from [lldb] [lldb-instr] Add missing linkage to ClangLex to [lldb] [lldb-instr] Add missing linkage to clang libraries.
mgorny edited the summary of this revision. (Show Details)

That's the complete set.

labath accepted this revision.Feb 11 2019, 1:42 AM

This happens when using the standalone build, right?

I suspect this happens only there because cmake does not have enough information to correctly include transitive deps automatically. That's slightly unfortunate, but I guess we can live with it.

This revision is now accepted and ready to land.Feb 11 2019, 1:42 AM

Yes, I'm using the standalone build. Thanks.

This revision was automatically updated to reflect the committed changes.