Page MenuHomePhabricator

[MemorySSA] Remove verifyClobberSanity.
ClosedPublic

Authored by asbirlea on Feb 8 2019, 1:28 PM.

Details

Summary

This verification may fail after certain transformations due to
BasicAA's fragility. Added a small explanation and a testcase that
triggers the assert in checkClobberSanity (before its removal).
Addresses PR40509.

Diff Detail

Event Timeline

asbirlea created this revision.Feb 8 2019, 1:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 8 2019, 1:28 PM

Thanks! Just a tiny nit

lib/Analysis/MemorySSA.cpp
1798 ↗(On Diff #186036)

If this is entirely unused now, can we stash the comments about how this isn't guaranteed in verifyMemorySSA and delete this method entirely? I'd rather not carry dead code. :)

asbirlea updated this revision to Diff 186297.Feb 11 2019, 11:20 AM

Address comment.

asbirlea marked an inline comment as done.Feb 11 2019, 11:20 AM
asbirlea edited the summary of this revision. (Show Details)

LGTM with one more nit. Thanks again!

lib/Analysis/MemorySSA.cpp
1799 ↗(On Diff #186297)

please also remove the declaration from MemorySSA.h

This revision is now accepted and ready to land.Feb 11 2019, 11:23 AM
asbirlea updated this revision to Diff 186302.Feb 11 2019, 11:42 AM
asbirlea edited the summary of this revision. (Show Details)

Address comment.

This revision was automatically updated to reflect the committed changes.