[NFC] Avoid passing blocks vector to the OutlineRegionInfo constructor by value.

[vsk]

llvm/lib/Transforms/IPO/PartialInlining.cpp

184 ↗

(On Diff #185988)

Consider ArrayRef<BasicBlock *>, to avoid leaking an implementation detail ("8")?

538 ↗

(On Diff #185988)

This copy seems dead?

[sdmitriev]

[NFC] Avoid passing blocks vector to the OutlineRegionInfo constructor by value.

Addressed review comments.

[sdmitriev]

Updated title.

[sdmitriev]

llvm/lib/Transforms/IPO/PartialInlining.cpp

184 ↗

(On Diff #185988)

Done.

538 ↗

(On Diff #185988)

Right, this assignment looks dead.

[vsk]

Thanks, lgtm.

llvm/trunk/lib/Transforms/IPO/PartialInlining.cpp

 };
 
 struct FunctionOutliningMultiRegionInfo {
   FunctionOutliningMultiRegionInfo()
       : ORI() {}
 
   // Container for outline regions
   struct OutlineRegionInfo {
-    OutlineRegionInfo(SmallVector<BasicBlock *, 8> Region,
+    OutlineRegionInfo(ArrayRef<BasicBlock *> Region,
                       BasicBlock *EntryBlock, BasicBlock *ExitBlock,
                       BasicBlock *ReturnBlock)
-        : Region(Region), EntryBlock(EntryBlock), ExitBlock(ExitBlock),
-          ReturnBlock(ReturnBlock) {}
+        : Region(Region.begin(), Region.end()), EntryBlock(EntryBlock),
+          ExitBlock(ExitBlock), ReturnBlock(ReturnBlock) {}
     SmallVector<BasicBlock *, 8> Region;
     BasicBlock *EntryBlock;
     BasicBlock *ExitBlock;
     BasicBlock *ReturnBlock;
   };
 
   SmallVector<OutlineRegionInfo, 4> ORI;
 };
#endif
       // variables.
       for (auto *BB : DominateVector)
         VisitedMap[BB] = true;
       // ReturnBlock here means the block after the outline call
       BasicBlock *ReturnBlock = ExitBlock->getSingleSuccessor();
       // assert(ReturnBlock && "ReturnBlock is NULL somehow!");
       FunctionOutliningMultiRegionInfo::OutlineRegionInfo RegInfo(
           DominateVector, DominateVector.front(), ExitBlock, ReturnBlock);
-      RegInfo.Region = DominateVector;
       OutliningInfo->ORI.push_back(RegInfo);
 #ifndef NDEBUG
       if (TracePartialInlining) {
         dbgs() << "Found Cold Candidate starting at block: "
                << DominateVector.front()->getName() << "\n";
       }
 #endif
       ColdCandidateFound = true;