Page MenuHomePhabricator

[NFC] Avoid passing blocks vector to the OutlineRegionInfo constructor by value.
ClosedPublic

Authored by sdmitriev on Fri, Feb 8, 9:10 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

sdmitriev created this revision.Fri, Feb 8, 9:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptFri, Feb 8, 9:10 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
vsk added inline comments.Fri, Feb 8, 10:00 AM
llvm/lib/Transforms/IPO/PartialInlining.cpp
184 ↗(On Diff #185988)

Consider ArrayRef<BasicBlock *>, to avoid leaking an implementation detail ("8")?

538 ↗(On Diff #185988)

This copy seems dead?

sdmitriev updated this revision to Diff 186016.Fri, Feb 8, 11:45 AM

[NFC] Avoid passing blocks vector to the OutlineRegionInfo constructor by value.

Addressed review comments.

sdmitriev updated this revision to Diff 186021.Fri, Feb 8, 11:52 AM
sdmitriev retitled this revision from [NFC] Pass blocks vector to the OutlineRegionInfo constructor by reference. to [NFC] Avoid passing blocks vector to the OutlineRegionInfo constructor by value..

Updated title.

sdmitriev marked 2 inline comments as done.Fri, Feb 8, 11:53 AM
sdmitriev added inline comments.
llvm/lib/Transforms/IPO/PartialInlining.cpp
184 ↗(On Diff #185988)

Done.

538 ↗(On Diff #185988)

Right, this assignment looks dead.

vsk accepted this revision.Fri, Feb 8, 12:08 PM

Thanks, lgtm.

This revision is now accepted and ready to land.Fri, Feb 8, 12:08 PM
This revision was automatically updated to reflect the committed changes.