This is an archive of the discontinued LLVM Phabricator instance.

Differential D57933

[WebAssembly] Fixed Disassembler ignoring endian swap on big endian.
ClosedPublic

Authored by aardappel on Feb 7 2019, 5:29 PM.

Details

Reviewers
aheejin
Commits
rG0d9f3f7f953e: [WebAssembly] Fixed Disassembler ignoring endian swap on big endian.
rL353496: [WebAssembly] Fixed Disassembler ignoring endian swap on big endian.
Summary

This fixes: https://bugs.llvm.org/show_bug.cgi?id=40620

Diff Detail

Event Timeline

aardappel created this revision.Feb 7 2019, 5:29 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 7 2019, 5:29 PM
Herald added subscribers: llvm-commits, sunfish, jgravelle-google and 2 others. · View Herald Transcript
Harbormaster completed remote builds in B27935: Diff 185901.Feb 7 2019, 5:29 PM
aheejin accepted this revision.Feb 7 2019, 5:39 PM
aheejin added inline comments.
test/MC/Disassembler/WebAssembly/wasm.txt
37

We can delete the comment now :)

This revision is now accepted and ready to land.Feb 7 2019, 5:39 PM
aardappel marked an inline comment as done.Feb 7 2019, 5:42 PM
aardappel updated this revision to Diff 185903.Feb 7 2019, 5:42 PM

Removed old comment.

Harbormaster completed remote builds in B27936: Diff 185903.Feb 7 2019, 5:44 PM
Closed by commit rL353496: [WebAssembly] Fixed Disassembler ignoring endian swap on big endian. (authored by aardappel). · Explain WhyFeb 7 2019, 5:44 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
Target/
WebAssembly/
Disassembler/
5 lines
test/
MC/
Disassembler/
WebAssembly/
2 lines

Diff 185901

lib/Target/WebAssembly/Disassembler/WebAssemblyDisassembler.cpp

Show First 20 Lines • Show All 102 Lines • ▼ Show 20 Linesstatic bool parseLEBImmediate(MCInst &MI, uint64_t &Size,
MI.addOperand(MCOperand::createImm(Val)); MI.addOperand(MCOperand::createImm(Val));
return true; return true;
} }
template <typename T> template <typename T>
bool parseImmediate(MCInst &MI, uint64_t &Size, ArrayRef<uint8_t> Bytes) { bool parseImmediate(MCInst &MI, uint64_t &Size, ArrayRef<uint8_t> Bytes) {
if (Size + sizeof(T) > Bytes.size()) if (Size + sizeof(T) > Bytes.size())
return false; return false;
T Val; T Val = support::endian::read<T, support::endianness::little, alignof(T)>(
memcpy(&Val, Bytes.data() + Size, sizeof(T)); Bytes.data() + Size);
support::endian::byte_swap<T, support::endianness::little>(Val);
Size += sizeof(T); Size += sizeof(T);
if (std::is_floating_point<T>::value) { if (std::is_floating_point<T>::value) {
MI.addOperand(MCOperand::createFPImm(static_cast<double>(Val))); MI.addOperand(MCOperand::createFPImm(static_cast<double>(Val)));
} else { } else {
MI.addOperand(MCOperand::createImm(static_cast<int64_t>(Val))); MI.addOperand(MCOperand::createImm(static_cast<int64_t>(Val)));
} }
return true; return true;
} }
▲ Show 20 Lines • Show All 156 Lines • Show Last 20 Lines

test/MC/Disassembler/WebAssembly/wasm.txt

Show All 28 Lines
# CHECK: local.get 128 # CHECK: local.get 128
0x20 0x80 0x01 0x20 0x80 0x01
# Prefix byte example: # Prefix byte example:
# CHECK: i64.trunc_sat_f64_u # CHECK: i64.trunc_sat_f64_u
0xFC 0x07 0xFC 0x07
# FIXME Disabled temporarily due to failures in clang-ppc64be-linux and # FIXME Disabled temporarily due to failures in clang-ppc64be-linux and
# clang-s390x-linux bots # clang-s390x-linux bots
aheejinUnsubmitted
Done
ReplyInline Actions

We can delete the comment now :)

aheejin: We can delete the comment now :)
# C HECK: v128.const 50462976, 117835012, 185207048, 252579084 # CHECK: v128.const 50462976, 117835012, 185207048, 252579084
0xFD 0x02 0x00 0x01 0x02 0x03 0x04 0x05 0x06 0x07 0x08 0x09 0x0A 0x0B 0x0C 0x0D 0x0E 0x0F 0xFD 0x02 0x00 0x01 0x02 0x03 0x04 0x05 0x06 0x07 0x08 0x09 0x0A 0x0B 0x0C 0x0D 0x0E 0x0F
# CHECK: v8x16.shuffle 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15 # CHECK: v8x16.shuffle 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
0xFD 0x03 0x00 0x01 0x02 0x03 0x04 0x05 0x06 0x07 0x08 0x09 0x0A 0x0B 0x0C 0x0D 0x0E 0x0F 0xFD 0x03 0x00 0x01 0x02 0x03 0x04 0x05 0x06 0x07 0x08 0x09 0x0A 0x0B 0x0C 0x0D 0x0E 0x0F
# Check LEB128 encoding of SIMD instructions # Check LEB128 encoding of SIMD instructions
# CHECK: i64x2.all_true # CHECK: i64x2.all_true
0xFD 0x86 0x01 0xFD 0x86 0x01
Show All 13 Lines