Page MenuHomePhabricator

Be conservative about unordered accesses for the moment
ClosedPublic

Authored by reames on Tue, Feb 5, 6:51 PM.

Details

Summary

Background: As described in https://reviews.llvm.org/D57601, I'm working towards separating volatile and atomic in the MMO uses for atomic instructions.

In https://reviews.llvm.org/D57593, I fixed a bug where isUnordered was returning the wrong result, but didn't account for the fact I was getting slightly ahead of myself. While both uses of isUnordered are correct (as far as I can tell), we don't have tests to demonstrate this and being aggressive gets in the way of having the removal of volatile truly be non-functional. Once D57601 lands, I will return to these call sites, revert this patch, and add the appropriate tests to show the expected behaviour.

Diff Detail

Repository
rL LLVM

Event Timeline

reames created this revision.Tue, Feb 5, 6:51 PM
jlebar accepted this revision.Mon, Feb 11, 2:39 PM

ping

Strangely this didn't show up in my inbox until you pinged it. Not sure why. :-/

This revision is now accepted and ready to land.Mon, Feb 11, 2:39 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMon, Feb 11, 3:37 PM