This is an archive of the discontinued LLVM Phabricator instance.

Support R_X86_64_PC8 and R_X86_64_PC16.
ClosedPublic

Authored by ruiu on Feb 5 2019, 5:36 PM.

Details

Summary

We found that we need R_X86_64_PC8 and R_X86_64_PC16, so is the patch.
They are defined by the x86-64 ELF ABI standard.

Diff Detail

Repository
rL LLVM

Event Timeline

ruiu created this revision.Feb 5 2019, 5:36 PM
grimar accepted this revision.Feb 6 2019, 12:46 AM

LGTM with a nit.

lld/test/ELF/x86-64-pcrel.s
8 ↗(On Diff #185456)

You want to use llvm-objdump, not GNU objdump.

This revision is now accepted and ready to land.Feb 6 2019, 12:46 AM
tmsriram accepted this revision.Feb 6 2019, 5:57 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 6 2019, 8:50 AM