[analyzer] [testing] Inside CmpRuns.py output also print the filename of the first item in the path

[george.karpenkov]

Summary

Otherwise, the last error may happen in a shared header, resulting in a massive duplication

[NoQ]

Yay, thanks! Looks useful.

clang/utils/analyzer/CmpRuns.py

class AnalysisDiagnostic(object):
 
     def getFileName(self):
         root = self._report.run.root
         fileName = self._report.files[self._loc['file']]
         if fileName.startswith(root) and len(root) > 0:
             return fileName[len(root) + 1:]
         return fileName
 
+    def getRootFileName(self):
+        path = self._data['path']
+        if not path:
+            return self.getFileName()
+        p = path[0]
+        if 'location' in p:
+            fIdx = p['location']['file']
+        else: # control edge
+            fIdx = path[0]['edges'][0]['start'][0]['file']
+        out = self._report.files[fIdx]
+        root = self._report.run.root
+        if out.startswith(root):
+            return out[len(root):]
+        return out
+
     def getLine(self):
         return self._loc['line']
 
     def getColumn(self):
         return self._loc['col']
 
     def getPathLength(self):
         return self._reportSize
def getReport(self):
             return " "
         return os.path.join(self._report.run.path, self._htmlReport)
 
     def getReadableName(self):
         if 'issue_context' in self._data:
             funcnamePostfix = "#" + self._data['issue_context']
         else:
             funcnamePostfix = ""
-        return '%s%s:%d:%d, %s: %s' % (self.getFileName(),
+        rootFilename = self.getRootFileName()
+        fileName = self.getFileName()
+        if rootFilename != fileName:
+            filePrefix = "[%s] %s" % (rootFilename, fileName)
+        else:
+            filePrefix = rootFilename
+        return '%s%s:%d:%d, %s: %s' % (filePrefix,
                                        funcnamePostfix,
                                        self.getLine(),
                                        self.getColumn(), self.getCategory(),
                                        self.getDescription())
 
     # Note, the data format is not an API and may change from one analyzer
     # version to another.
     def getRawData(self):