This is an archive of the discontinued LLVM Phabricator instance.

Differential D57765

[ARM] Add Cortex-M35P Support
ClosedPublic

Authored by LukeCheeseman on Feb 5 2019, 9:28 AM.

Details

Reviewers
olista01
Commits
rG8a5006ca2511: [ARM] Add Cortex-M35P Support
rC356742: [ARM] Add Cortex-M35P Support
rL356742: [ARM] Add Cortex-M35P Support
Summary
  • Add clang frontend testing for Cortex-M35P

Diff Detail

Event Timeline

LukeCheeseman created this revision.Feb 5 2019, 9:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 5 2019, 9:28 AM
Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. · View Herald Transcript
olista01 requested changes to this revision.Feb 6 2019, 5:24 AM
olista01 added inline comments.
test/Driver/arm-cortex-cpus.c
826

I think this should also check that the correct CPU is passed to cc1, because you've defined a ProcessorModel in the backend.

This revision now requires changes to proceed.Feb 6 2019, 5:24 AM
LukeCheeseman updated this revision to Diff 188364.Feb 26 2019, 6:26 AM
  • Test cpus Cortex-M33 and Cortex-M35P seperately
LukeCheeseman added a comment.Mar 14 2019, 2:55 AM

ping

olista01 accepted this revision.Mar 14 2019, 3:31 AM

LGTM

This revision is now accepted and ready to land.Mar 14 2019, 3:31 AM
Closed by commit rL356742: [ARM] Add Cortex-M35P Support (authored by LukeCheeseman). · Explain WhyMar 22 2019, 3:57 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMar 22 2019, 3:57 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript

Revision Contents

PathSize
test/
Driver/
1 line

Diff 185333

test/Driver/arm-cortex-cpus.c

Context not available.
// CHECK-CPUV8MBASE: "-cc1"{{.*}} "-triple" "thumbv8m.base- // CHECK-CPUV8MBASE: "-cc1"{{.*}} "-triple" "thumbv8m.base-
// RUN: %clang -target arm -mcpu=cortex-m33 -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-CPUV8MMAIN %s // RUN: %clang -target arm -mcpu=cortex-m33 -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-CPUV8MMAIN %s
// RUN: %clang -target arm -mcpu=cortex-m35p -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-CPUV8MMAIN %s
olista01Unsubmitted
Not Done
ReplyInline Actions

I think this should also check that the correct CPU is passed to cc1, because you've defined a ProcessorModel in the backend.

olista01: I think this should also check that the correct CPU is passed to cc1, because you've defined a…
// CHECK-CPUV8MMAIN: "-cc1"{{.*}} "-triple" "thumbv8m.main- // CHECK-CPUV8MMAIN: "-cc1"{{.*}} "-triple" "thumbv8m.main-
// ================== Check whether -mcpu accepts mixed-case values. // ================== Check whether -mcpu accepts mixed-case values.
Context not available.