Page MenuHomePhabricator

[Clang][NCF] Sanitizer options: helpers to check if {Kernel,Hardware}ASan is enabled
AbandonedPublic

Authored by yln on Mon, Feb 4, 4:10 PM.

Details

Reviewers
vsk
eugenis
kcc
Summary

Kernel ASan is basically ASan with a few specific settings, but has a
seperate front-end flag. Provide a helper that checks for both, so new
comitters like myself are less likely to forget the Kernel variant.

Event Timeline

yln created this revision.Mon, Feb 4, 4:10 PM
Herald added a project: Restricted Project. · View Herald TranscriptMon, Feb 4, 4:10 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
yln added a reviewer: vsk.Mon, Feb 4, 4:11 PM
vsk added inline comments.
clang/include/clang/Basic/Sanitizers.h
89

Sorry to bike-shed, but this seems a bit hard to read. How about: 'hasAnyASan'?

I find the current code more readable than with this change.

yln abandoned this revision.Mon, Feb 4, 6:10 PM