This is an archive of the discontinued LLVM Phabricator instance.

Differential D57695

[llvm-readobj] Report more WebAssembly symbol info
ClosedPublic

Authored by sbc100 on Feb 4 2019, 9:22 AM.

Details

Reviewers
dschuff
Commits
rG3fd2462d031f: [llvm-readobj] Report more WebAssembly symbol info
rL353104: [llvm-readobj] Report more WebAssembly symbol info

Diff Detail

Repository
rL LLVM

Event Timeline

sbc100 created this revision.Feb 4 2019, 9:22 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 4 2019, 9:22 AM
Herald added subscribers: llvm-commits, rupprecht, sunfish and 3 others. · View Herald Transcript
sbc100 added a reviewer: dschuff.Feb 4 2019, 9:23 AM
Harbormaster completed remote builds in B27674: Diff 185069.Feb 4 2019, 9:23 AM
dschuff accepted this revision.Feb 4 2019, 2:21 PM
This revision is now accepted and ready to land.Feb 4 2019, 2:21 PM
Closed by commit rL353104: [llvm-readobj] Report more WebAssembly symbol info (authored by sbc). · Explain WhyFeb 4 2019, 2:27 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
trunk/
test/
MC/
WebAssembly/
12 lines
tools/
llvm-readobj/
9 lines

Diff 185161

llvm/trunk/test/MC/WebAssembly/debug-info.ll

Show First 20 Lines • Show All 160 Lines • ▼ Show 20 Lines
; CHECK-NEXT: 0x2B R_WASM_FUNCTION_OFFSET_I32 f2 0 ; CHECK-NEXT: 0x2B R_WASM_FUNCTION_OFFSET_I32 f2 0
; CHECK-NEXT: } ; CHECK-NEXT: }
; CHECK-NEXT:] ; CHECK-NEXT:]
; CHECK-NEXT:Symbols [ ; CHECK-NEXT:Symbols [
; CHECK-NEXT: Symbol { ; CHECK-NEXT: Symbol {
; CHECK-NEXT: Name: f2 ; CHECK-NEXT: Name: f2
; CHECK-NEXT: Type: FUNCTION (0x0) ; CHECK-NEXT: Type: FUNCTION (0x0)
; CHECK-NEXT: Flags: 0x4 ; CHECK-NEXT: Flags: 0x4
; CHECK-NEXT: ElementIndex: 0x0
; CHECK-NEXT: } ; CHECK-NEXT: }
; CHECK-NEXT: Symbol { ; CHECK-NEXT: Symbol {
; CHECK-NEXT: Name: foo ; CHECK-NEXT: Name: foo
; CHECK-NEXT: Type: DATA (0x1) ; CHECK-NEXT: Type: DATA (0x1)
; CHECK-NEXT: Flags: 0x4 ; CHECK-NEXT: Flags: 0x4
; CHECK-NEXT: Offset: 0x0
; CHECK-NEXT: Segment: 0x0
; CHECK-NEXT: Size: 0x4
; CHECK-NEXT: } ; CHECK-NEXT: }
; CHECK-NEXT: Symbol { ; CHECK-NEXT: Symbol {
; CHECK-NEXT: Name: myextern ; CHECK-NEXT: Name: myextern
; CHECK-NEXT: Type: DATA (0x1) ; CHECK-NEXT: Type: DATA (0x1)
; CHECK-NEXT: Flags: 0x10 ; CHECK-NEXT: Flags: 0x10
; CHECK-NEXT: Module:
; CHECK-NEXT: } ; CHECK-NEXT: }
; CHECK-NEXT: Symbol { ; CHECK-NEXT: Symbol {
; CHECK-NEXT: Name: ptr2 ; CHECK-NEXT: Name: ptr2
; CHECK-NEXT: Type: DATA (0x1) ; CHECK-NEXT: Type: DATA (0x1)
; CHECK-NEXT: Flags: 0x4 ; CHECK-NEXT: Flags: 0x4
; CHECK-NEXT: Offset: 0x0
; CHECK-NEXT: Segment: 0x1
; CHECK-NEXT: Size: 0x4
; CHECK-NEXT: } ; CHECK-NEXT: }
; CHECK-NEXT: Symbol { ; CHECK-NEXT: Symbol {
; CHECK-NEXT: Name: .debug_str ; CHECK-NEXT: Name: .debug_str
; CHECK-NEXT: Type: SECTION (0x3) ; CHECK-NEXT: Type: SECTION (0x3)
; CHECK-NEXT: Flags: 0x2 ; CHECK-NEXT: Flags: 0x2
; CHECK-NEXT: ElementIndex: 0x6
; CHECK-NEXT: } ; CHECK-NEXT: }
; CHECK-NEXT: Symbol { ; CHECK-NEXT: Symbol {
; CHECK-NEXT: Name: .debug_abbrev ; CHECK-NEXT: Name: .debug_abbrev
; CHECK-NEXT: Type: SECTION (0x3) ; CHECK-NEXT: Type: SECTION (0x3)
; CHECK-NEXT: Flags: 0x2 ; CHECK-NEXT: Flags: 0x2
; CHECK-NEXT: ElementIndex: 0x7
; CHECK-NEXT: } ; CHECK-NEXT: }
; CHECK-NEXT: Symbol { ; CHECK-NEXT: Symbol {
; CHECK-NEXT: Name: .debug_info ; CHECK-NEXT: Name: .debug_info
; CHECK-NEXT: Type: SECTION (0x3) ; CHECK-NEXT: Type: SECTION (0x3)
; CHECK-NEXT: Flags: 0x2 ; CHECK-NEXT: Flags: 0x2
; CHECK-NEXT: ElementIndex: 0x8
; CHECK-NEXT: } ; CHECK-NEXT: }
; CHECK-NEXT: Symbol { ; CHECK-NEXT: Symbol {
; CHECK-NEXT: Name: .debug_line ; CHECK-NEXT: Name: .debug_line
; CHECK-NEXT: Type: SECTION (0x3) ; CHECK-NEXT: Type: SECTION (0x3)
; CHECK-NEXT: Flags: 0x2 ; CHECK-NEXT: Flags: 0x2
; CHECK-NEXT: ElementIndex: 0xC
; CHECK-NEXT: } ; CHECK-NEXT: }
; CHECK-NEXT:] ; CHECK-NEXT:]
; generated from the following C code using: clang --target=wasm32 -g -O0 -S -emit-llvm test.c ; generated from the following C code using: clang --target=wasm32 -g -O0 -S -emit-llvm test.c
; extern int myextern; ; extern int myextern;
; void f2(void) { return; } ; void f2(void) { return; }
; ;
; int* foo = &myextern; ; int* foo = &myextern;
▲ Show 20 Lines • Show All 41 Lines • Show Last 20 Lines

llvm/trunk/tools/llvm-readobj/WasmDumper.cpp

Show First 20 Lines • Show All 204 Lines • ▼ Show 20 Lines
} }
void WasmDumper::printSymbol(const SymbolRef &Sym) { void WasmDumper::printSymbol(const SymbolRef &Sym) {
DictScope D(W, "Symbol"); DictScope D(W, "Symbol");
WasmSymbol Symbol = Obj->getWasmSymbol(Sym.getRawDataRefImpl()); WasmSymbol Symbol = Obj->getWasmSymbol(Sym.getRawDataRefImpl());
W.printString("Name", Symbol.Info.Name); W.printString("Name", Symbol.Info.Name);
W.printEnum("Type", Symbol.Info.Kind, makeArrayRef(WasmSymbolTypes)); W.printEnum("Type", Symbol.Info.Kind, makeArrayRef(WasmSymbolTypes));
W.printHex("Flags", Symbol.Info.Flags); W.printHex("Flags", Symbol.Info.Flags);
if (Symbol.Info.Flags & wasm::WASM_SYMBOL_UNDEFINED)
W.printString("Module", Symbol.Info.Module);
if (Symbol.Info.Kind != wasm::WASM_SYMBOL_TYPE_DATA) {
W.printHex("ElementIndex", Symbol.Info.ElementIndex);
} else if (!(Symbol.Info.Flags & wasm::WASM_SYMBOL_UNDEFINED)) {
W.printHex("Offset", Symbol.Info.DataRef.Offset);
W.printHex("Segment", Symbol.Info.DataRef.Segment);
W.printHex("Size", Symbol.Info.DataRef.Size);
}
} }
} // namespace } // namespace
namespace llvm { namespace llvm {
std::error_code createWasmDumper(const object::ObjectFile *Obj, std::error_code createWasmDumper(const object::ObjectFile *Obj,
ScopedPrinter &Writer, ScopedPrinter &Writer,
Show All 9 Lines