The backend used to print the x87 FPSW register as 'fpsw', but gcc inline asm uses 'fpsr'. After D57641, the backend now uses 'fpsr' to match. So we need to update the test and we can remove the code that excluded the 'fpsw' string.
Details
Details
- Reviewers
rnk - Commits
- rGe5523662b5b2: Merging r353142: --------------------------------------------------------------…
rL353819: Merging r353142:
rG879a45633ddf: [X86] Change MS inline asm clobber list filter to check for 'fpsr' instead of…
rC353142: [X86] Change MS inline asm clobber list filter to check for 'fpsr' instead of…
rL353142: [X86] Change MS inline asm clobber list filter to check for 'fpsr' instead of…
Diff Detail
Diff Detail
- Repository
- rC Clang
- Build Status
Buildable 27712 Build 27711: arc lint + arc unit
Event Timeline
test/CodeGen/ms-inline-asm.c | ||
---|---|---|
574 ↗ | (On Diff #184917) | Two fpsr? If we manually add that as an extra constraint, maybe we should remove that logic in this change. |
test/CodeGen/ms-inline-asm.c | ||
---|---|---|
574 ↗ | (On Diff #184917) | We slap "~{dirflag},~{fpsr},~{flags}" blindly onto both gcc and MS inline assembly. There are tests cases in this file with two ~{flags} as well. |
lib/Parse/ParseStmtAsm.cpp | ||
---|---|---|
637–639 | In light of this comment about "clang always adding fpsr anyway" I'd rather keep the fpsr filter here. |
In light of this comment about "clang always adding fpsr anyway" I'd rather keep the fpsr filter here.