This is an archive of the discontinued LLVM Phabricator instance.

[X86] Update clobber list in a test after D57641. Remove filter for 'fpsw' in MS inline asm clobber list generation since the backend now uses 'fpsr'.
ClosedPublic

Authored by craig.topper on Feb 2 2019, 1:44 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

craig.topper created this revision.Feb 2 2019, 1:44 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 2 2019, 1:44 PM
rnk added inline comments.Feb 4 2019, 3:04 PM
test/CodeGen/ms-inline-asm.c
574 ↗(On Diff #184917)

Two fpsr? If we manually add that as an extra constraint, maybe we should remove that logic in this change.

craig.topper marked an inline comment as done.Feb 4 2019, 3:07 PM
craig.topper added inline comments.
test/CodeGen/ms-inline-asm.c
574 ↗(On Diff #184917)

We slap "~{dirflag},~{fpsr},~{flags}" blindly onto both gcc and MS inline assembly. There are tests cases in this file with two ~{flags} as well.

rnk added inline comments.Feb 4 2019, 3:14 PM
lib/Parse/ParseStmtAsm.cpp
637–639 ↗(On Diff #184917)

In light of this comment about "clang always adding fpsr anyway" I'd rather keep the fpsr filter here.

Keep the filter on fpsw, but change the string to fpsr

rnk accepted this revision.Feb 4 2019, 5:39 PM

Thanks!

This revision is now accepted and ready to land.Feb 4 2019, 5:39 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 4 2019, 10:14 PM