Page MenuHomePhabricator

[NewPM][MSan] Add Options Handling
ClosedPublic

Authored by philip.pfaffe on Feb 2 2019, 12:49 PM.

Details

Summary

This patch enables passing options to msan via the passes pipeline, e.e., -passes=msan<recover;kernel;track-origins=4>.

Diff Detail

Repository
rC Clang

Event Timeline

philip.pfaffe created this revision.Feb 2 2019, 12:49 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 2 2019, 12:49 PM
fedor.sergeev added inline comments.Feb 4 2019, 12:12 AM
llvm/include/llvm/Transforms/Instrumentation/MemorySanitizer.h
32 ↗(On Diff #184910)

Is there a reason why this function no longer specifies default value for the parameter?
Before the change it was possible to call it w/o passing anything at all.

Btw, there is one use - in llvm/bindings/go/llvm/InstrumentationBindings.cpp, which dont seem to be addressed
by your change and it does call createMemorySanitizerLegacyPassPass w/o passing arguments.

Add the default argument back.

This revision is now accepted and ready to land.Feb 4 2019, 12:54 PM
Closed by commit rC353090: [NewPM][MSan] Add Options Handling (authored by pfaffe, committed by ). · Explain WhyFeb 4 2019, 1:02 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 4 2019, 1:02 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript

Minor past-commit nit.

lib/CodeGen/BackendUtil.cpp
1039

This change isn't needed any more (since you added the default back).