This is an archive of the discontinued LLVM Phabricator instance.

Compute the correct symbol size in llvm-nm even without --print-size
ClosedPublic

Authored by Sunil_Srivastava on Feb 1 2019, 10:00 AM.

Details

Summary

In llvm-nm, the symbol size was being computed only with --print-size option,
even though it was being printed in other cases, such as with --format=posix.

This patch simply removes the guard, so that the size is computed
independently of the later decision to print it or not.

Fixes PR39997.

Diff Detail

Repository
rL LLVM

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptFeb 1 2019, 10:00 AM
Herald added a subscriber: rupprecht. · View Herald Transcript
thegameg accepted this revision.Feb 1 2019, 12:55 PM
thegameg added subscribers: mtrent, thegameg.

LGTM, thanks!

This revision is now accepted and ready to land.Feb 1 2019, 12:55 PM
This revision was automatically updated to reflect the committed changes.