Page MenuHomePhabricator

Sunil_Srivastava (Sunil Srivastava)
User

Projects

User does not belong to any projects.

User Details

User Since
May 1 2015, 10:24 AM (216 w, 5 d)

Recent Activity

Mar 14 2019

Sunil_Srivastava committed rG6823c823d198: Handle consecutive-double-quotes in Windows argument parsing (authored by Sunil_Srivastava).
Handle consecutive-double-quotes in Windows argument parsing
Mar 14 2019, 12:25 PM

Mar 8 2019

Sunil_Srivastava committed rGae8fe4e09314: Improve "llvm-nm -f sysv" output for Elf files (authored by Sunil_Srivastava).
Improve "llvm-nm -f sysv" output for Elf files
Mar 8 2019, 2:02 PM

Mar 7 2019

Sunil_Srivastava added inline comments to D59060: Compute and Print Type and Section columns in "llvm-nm -f sysv" output. Round 2..
Mar 7 2019, 11:33 AM · Restricted Project
Sunil_Srivastava added inline comments to D59060: Compute and Print Type and Section columns in "llvm-nm -f sysv" output. Round 2..
Mar 7 2019, 9:48 AM · Restricted Project
Sunil_Srivastava updated the diff for D59060: Compute and Print Type and Section columns in "llvm-nm -f sysv" output. Round 2..

Replaced tab with spaces.

Mar 7 2019, 9:30 AM · Restricted Project
Sunil_Srivastava added inline comments to D59060: Compute and Print Type and Section columns in "llvm-nm -f sysv" output. Round 2..
Mar 7 2019, 9:30 AM · Restricted Project

Mar 6 2019

Sunil_Srivastava abandoned D58263: Compute and Print Type and Section columns in "llvm-nm -f sysv" output..

Replaced by https://reviews.llvm.org/D59060

Mar 6 2019, 5:23 PM · Restricted Project
Sunil_Srivastava created D59060: Compute and Print Type and Section columns in "llvm-nm -f sysv" output. Round 2..
Mar 6 2019, 4:33 PM · Restricted Project

Mar 1 2019

Sunil_Srivastava added a comment to D58662: Handle consecutive-double-quotes in Windows argument parsing.

Hi Reid,

Mar 1 2019, 11:21 AM · Restricted Project

Feb 27 2019

Sunil_Srivastava added a comment to D58662: Handle consecutive-double-quotes in Windows argument parsing.

Thanks for the lgtm Reid, but unfortunately our internal testing found a case where this path causes trouble.

Feb 27 2019, 4:26 PM · Restricted Project

Feb 26 2019

Sunil_Srivastava reopened D58263: Compute and Print Type and Section columns in "llvm-nm -f sysv" output..

This checkin has been reverted due to an ASAN buildbot failure.

Feb 26 2019, 11:31 AM · Restricted Project

Feb 25 2019

Sunil_Srivastava abandoned D12857: A warning for enumerations that do not fit in four bytes.
Feb 25 2019, 8:26 PM
Sunil_Srivastava added a comment to D58662: Handle consecutive-double-quotes in Windows argument parsing.

In terms of practical effect, this patch allows users to do, on Windows,

Feb 25 2019, 8:17 PM · Restricted Project
Sunil_Srivastava created D58662: Handle consecutive-double-quotes in Windows argument parsing.
Feb 25 2019, 5:59 PM · Restricted Project
Sunil_Srivastava committed rGd72d16f4448f: Improve "llvm-nm -f sysv" output for Elf files (authored by Sunil_Srivastava).
Improve "llvm-nm -f sysv" output for Elf files
Feb 25 2019, 4:22 PM
Sunil_Srivastava added a comment to D58263: Compute and Print Type and Section columns in "llvm-nm -f sysv" output..

Thx mtrent.

Feb 25 2019, 4:21 PM · Restricted Project

Feb 14 2019

Sunil_Srivastava added a comment to D58263: Compute and Print Type and Section columns in "llvm-nm -f sysv" output..

To clarify, this patch is only attempting to fix ELF files.

Feb 14 2019, 7:59 PM · Restricted Project
Sunil_Srivastava created D58263: Compute and Print Type and Section columns in "llvm-nm -f sysv" output..
Feb 14 2019, 4:49 PM · Restricted Project

Feb 3 2019

Sunil_Srivastava committed rGb33b410283e2: Compute the correct symbol size in llvm-nm even without --print-size (authored by Sunil_Srivastava).
Compute the correct symbol size in llvm-nm even without --print-size
Feb 3 2019, 2:40 PM

Feb 1 2019

Sunil_Srivastava added a reviewer for D57599: Compute the correct symbol size in llvm-nm even without --print-size: enderby.
Feb 1 2019, 10:02 AM · Restricted Project
Sunil_Srivastava created D57599: Compute the correct symbol size in llvm-nm even without --print-size.
Feb 1 2019, 10:00 AM · Restricted Project

Nov 19 2018

Sunil_Srivastava abandoned D41474: Fix a crash in lazy loading of Metadata in ThinLTO.

Abandoned in favor of https://reviews.llvm.org/D53596

Nov 19 2018, 2:44 PM

Aug 21 2018

Sunil_Srivastava accepted D51021: ABI-Testsuite: Force the old c++11 ABI in mangling/test.xpp.

LGTM

Aug 21 2018, 9:52 AM

Jun 5 2018

Sunil_Srivastava updated the diff for D47291: Proposal to make rtti errors more generic..

Changed as per Paul's suggestion.

Jun 5 2018, 2:10 PM
Sunil_Srivastava added inline comments to D47291: Proposal to make rtti errors more generic..
Jun 5 2018, 2:10 PM

Jun 4 2018

Sunil_Srivastava added inline comments to D47291: Proposal to make rtti errors more generic..
Jun 4 2018, 2:22 PM

May 23 2018

Sunil_Srivastava added reviewers for D47291: Proposal to make rtti errors more generic.: thakis, aadg.
May 23 2018, 4:58 PM
Sunil_Srivastava created D47291: Proposal to make rtti errors more generic..
May 23 2018, 3:16 PM

May 16 2018

Sunil_Srivastava created D46982: Do not enable RTTI with -fexceptions, for PS4.
May 16 2018, 3:25 PM

May 14 2018

Sunil_Srivastava added a reviewer for D46836: Fix some rtti-options tests: filcab.
May 14 2018, 9:51 AM
Sunil_Srivastava created D46836: Fix some rtti-options tests.
May 14 2018, 9:50 AM

Feb 21 2018

Sunil_Srivastava abandoned D22529: Inlining of empty/small variadic functions..
Feb 21 2018, 11:56 AM

Jan 9 2018

Sunil_Srivastava added a comment to D41474: Fix a crash in lazy loading of Metadata in ThinLTO.

The thing that I do not understand is that, even though the error happens while reading EchoD2, a change in DeltaD2 avoid the error.

Jan 9 2018, 10:56 AM

Jan 8 2018

Sunil_Srivastava updated the diff for D41474: Fix a crash in lazy loading of Metadata in ThinLTO.

I have trimmed the .ll test somewhat, but I am not sure what is the exact structure that is leading to this error.

Jan 8 2018, 5:37 PM

Dec 21 2017

Sunil_Srivastava added a comment to D41474: Fix a crash in lazy loading of Metadata in ThinLTO.

What created the forward ref? Do you know why it wasn't resolved in the usual way?

Dec 21 2017, 9:38 AM

Dec 20 2017

Sunil_Srivastava created D41474: Fix a crash in lazy loading of Metadata in ThinLTO.
Dec 20 2017, 5:43 PM

Jun 26 2017

Sunil_Srivastava updated the diff for D22529: Inlining of empty/small variadic functions..

Took care of the 'nits' and updated to the current version of llvm.

Jun 26 2017, 11:46 AM

Jun 19 2017

D22529: Inlining of empty/small variadic functions. now requires changes to proceed.
Jun 19 2017, 2:32 PM

Jan 23 2017

Sunil_Srivastava added a comment to D22529: Inlining of empty/small variadic functions..

ping

Jan 23 2017, 2:18 PM
Sunil_Srivastava added a comment to D22057: Prevent devirtualization of calls to un-instantiated functions..

Ping

Jan 23 2017, 2:18 PM

Dec 12 2016

Sunil_Srivastava added a comment to D22529: Inlining of empty/small variadic functions..

A friendly ping please

Dec 12 2016, 12:54 PM
Sunil_Srivastava added a comment to D22057: Prevent devirtualization of calls to un-instantiated functions..

A friendly ping.

Dec 12 2016, 12:53 PM

Oct 19 2016

Sunil_Srivastava added a comment to D22529: Inlining of empty/small variadic functions..

ping

Oct 19 2016, 4:58 PM
Sunil_Srivastava added a comment to D22057: Prevent devirtualization of calls to un-instantiated functions..

ping

Oct 19 2016, 4:57 PM

Oct 3 2016

Sunil_Srivastava added a comment to D22057: Prevent devirtualization of calls to un-instantiated functions..

Ping

Oct 3 2016, 11:43 AM

Sep 29 2016

Sunil_Srivastava added a comment to D22529: Inlining of empty/small variadic functions..

What's the motivation to inline cases where a variadic function calls some other variadic function but not with 'musttail'?

Sep 29 2016, 10:47 PM

Sep 28 2016

Sunil_Srivastava updated the diff for D22529: Inlining of empty/small variadic functions..

This is an update to inlining-of-variadic-functions change along the lines of suggestion by Chandler.

Sep 28 2016, 5:09 PM

Sep 14 2016

Sunil_Srivastava updated the diff for D22057: Prevent devirtualization of calls to un-instantiated functions..

This is an update to address points raised by Richard Smith:

Sep 14 2016, 3:19 PM

Sep 7 2016

Sunil_Srivastava added inline comments to D22057: Prevent devirtualization of calls to un-instantiated functions..
Sep 7 2016, 5:11 PM

Jul 19 2016

Sunil_Srivastava retitled D22529: Inlining of empty/small variadic functions. from to Inlining of empty/small variadic functions..
Jul 19 2016, 1:47 PM

Jul 18 2016

Sunil_Srivastava added a comment to D22057: Prevent devirtualization of calls to un-instantiated functions..

Ping.

Jul 18 2016, 10:08 AM

Jul 6 2016

Sunil_Srivastava retitled D22057: Prevent devirtualization of calls to un-instantiated functions. from to Prevent devirtualization of calls to un-instantiated functions..
Jul 6 2016, 10:45 AM

Apr 26 2016

Sunil_Srivastava closed D19552: Check 'r' and 'y specifiers of freebsd_kernel_printf format strings on PS4.

Submitted as r267625.

Apr 26 2016, 5:03 PM
Sunil_Srivastava added a comment to D19552: Check 'r' and 'y specifiers of freebsd_kernel_printf format strings on PS4.

I had put these 'h' test lines to test the first of my changes, and this sufficed, but you are correct. I should add %y too. I am going to add '%hr' and '%hy'.

Apr 26 2016, 3:29 PM
Sunil_Srivastava retitled D19552: Check 'r' and 'y specifiers of freebsd_kernel_printf format strings on PS4 from to Check 'r' and 'y specifiers of freebsd_kernel_printf format strings on PS4.
Apr 26 2016, 12:51 PM

Feb 12 2016

Sunil_Srivastava updated the diff for D15095: Accept "-Weverything" in pragma clang diagnostic ....

Hi Richard,

Feb 12 2016, 3:39 PM
Sunil_Srivastava updated the diff for D15095: Accept "-Weverything" in pragma clang diagnostic ....

Hi Richard,

Feb 12 2016, 3:36 PM

Feb 11 2016

Sunil_Srivastava updated the diff for D15095: Accept "-Weverything" in pragma clang diagnostic ....

Hi Richard,

Can you move the special case code out of DiagnosticsEngine and into the pragma handler for now?

Feb 11 2016, 12:58 PM

Feb 10 2016

Sunil_Srivastava added a comment to D15095: Accept "-Weverything" in pragma clang diagnostic ....

Richard, Your comment and my concern about the getDiagnosticsInGroup is still visible in the greyed out area.

Feb 10 2016, 1:14 PM
Sunil_Srivastava updated the diff for D15095: Accept "-Weverything" in pragma clang diagnostic ....

Changed the test, but the compiler code is still same, pending reply from Richard Smith

Feb 10 2016, 1:10 PM

Feb 5 2016

Sunil_Srivastava retitled D16788: Do not honor explicit alignment attribute on fields for PS4. from PS4 ABI Round 2. Actual PS4 code. to Do not honor explicit alignment attribute on fields for PS4..
Feb 5 2016, 12:53 PM
Sunil_Srivastava updated the diff for D16788: Do not honor explicit alignment attribute on fields for PS4..

Changed the patch based of feedback from John McCall.

Feb 5 2016, 10:13 AM

Feb 1 2016

Sunil_Srivastava added a reviewer for D16788: Do not honor explicit alignment attribute on fields for PS4.: wristow.
Feb 1 2016, 5:00 PM
Sunil_Srivastava retitled D16788: Do not honor explicit alignment attribute on fields for PS4. from Ps4 ABI Round 2. Actual PS4 code. to PS4 ABI Round 2. Actual PS4 code..
Feb 1 2016, 4:11 PM
Sunil_Srivastava retitled D16788: Do not honor explicit alignment attribute on fields for PS4. from to Ps4 ABI Round 2. Actual PS4 code..
Feb 1 2016, 4:11 PM

Jan 26 2016

Sunil_Srivastava retitled D16607: Implementation of PS4 ABI, round 1 from to Implementation of PS4 ABI, round 1.
Jan 26 2016, 3:19 PM

Dec 8 2015

Sunil_Srivastava added a comment to D15095: Accept "-Weverything" in pragma clang diagnostic ....

Please see the comment about getAllDiagnostics

Dec 8 2015, 2:43 PM

Nov 30 2015

Sunil_Srivastava updated D15095: Accept "-Weverything" in pragma clang diagnostic ....
Nov 30 2015, 3:53 PM
Sunil_Srivastava retitled D15095: Accept "-Weverything" in pragma clang diagnostic ... from to Accept "-Weverything" in pragma clang diagnostic ....
Nov 30 2015, 3:51 PM

Sep 14 2015

Sunil_Srivastava retitled D12857: A warning for enumerations that do not fit in four bytes from to A warning for enumerations that do not fit in four bytes.
Sep 14 2015, 11:51 AM

Jul 14 2015

Sunil_Srivastava closed D9481: Change in symbol renaming to help demanglers and debuggers.
Jul 14 2015, 1:30 PM
Sunil_Srivastava closed D9483: Change in symbol renaming to help demanglers and debugger. clang part..
Jul 14 2015, 1:30 PM
Sunil_Srivastava closed D10452: Fix for bug 22941, [asm inline] integer template parameter ....

submitted in r242175

Jul 14 2015, 1:29 PM

Jul 8 2015

Sunil_Srivastava added a comment to D10452: Fix for bug 22941, [asm inline] integer template parameter ....

ping

Jul 8 2015, 9:44 AM

Jul 2 2015

Sunil_Srivastava added a comment to D10908: [CodeGen] Don't crash classifying a union of an AVX vector and an int.

This change fixes the assertion failure in my full test case of several hundred combinations.

Jul 2 2015, 3:28 PM

Jun 24 2015

Sunil_Srivastava updated the diff for D10452: Fix for bug 22941, [asm inline] integer template parameter ....

Moved declaration of Result to just before its use.
The test is same as original, but added it back.

Jun 24 2015, 5:21 PM
Sunil_Srivastava added a comment to D10452: Fix for bug 22941, [asm inline] integer template parameter ....

ping

Jun 24 2015, 4:35 PM

Jun 17 2015

Sunil_Srivastava updated the diff for D10452: Fix for bug 22941, [asm inline] integer template parameter ....

Changed along the lines suggested by David Majnemer

Jun 17 2015, 2:59 PM

Jun 15 2015

Sunil_Srivastava retitled D10452: Fix for bug 22941, [asm inline] integer template parameter ... from to Fix for bug 22941, [asm inline] integer template parameter ....
Jun 15 2015, 11:30 AM

May 12 2015

Sunil_Srivastava added a comment to D9483: Change in symbol renaming to help demanglers and debugger. clang part..

Thanks. Submitted in r237151.

May 12 2015, 11:23 AM
Sunil_Srivastava added a comment to D9481: Change in symbol renaming to help demanglers and debuggers.

Thanks. Submitted in r237150

May 12 2015, 11:22 AM

May 4 2015

Sunil_Srivastava updated subscribers of D9481: Change in symbol renaming to help demanglers and debuggers.
May 4 2015, 12:05 PM
Sunil_Srivastava retitled D9483: Change in symbol renaming to help demanglers and debugger. clang part. from to Change in symbol renaming to help demanglers and debugger. clang part..
May 4 2015, 12:05 PM
Sunil_Srivastava retitled D9481: Change in symbol renaming to help demanglers and debuggers from to Change in symbol renaming to help demanglers and debuggers.
May 4 2015, 11:26 AM