This is an archive of the discontinued LLVM Phabricator instance.

Differential D57589

[libFuzzer][Windows] Clean up RawPrint
ClosedPublic

Authored by metzman on Feb 1 2019, 7:28 AM.

Details

Reviewers
vitalybuka
Commits
rG7c907bac6fd5: [libFuzzer][Windows] Clean up RawPrint
rCRT353108: [libFuzzer][Windows] Clean up RawPrint
rL353108: [libFuzzer][Windows] Clean up RawPrint
Summary

Use _write instead of the deprecated alias write on Windows.
Also, remove comment saying RawPrint is untested on Windows.

Diff Detail

Repository
rL LLVM

Event Timeline

metzman created this revision.Feb 1 2019, 7:28 AM
Harbormaster completed remote builds in B27613: Diff 184751.Feb 1 2019, 7:28 AM
metzman added a reviewer: vitalybuka.EditedFeb 1 2019, 7:39 AM
metzman added a subscriber: vitalybuka.

@vitalybuka
Please take a look at this small change.

metzman retitled this revision from [libFuzzer][Win] Use _write instead of write to [libFuzzer][Windows] Use _write instead of write.Feb 1 2019, 7:40 AM
metzman retitled this revision from [libFuzzer][Windows] Use _write instead of write to [libFuzzer][Windows] Clean up RawPrint.
vitalybuka accepted this revision.Feb 4 2019, 1:48 PM

LGTM

This revision is now accepted and ready to land.Feb 4 2019, 1:48 PM
Closed by commit rL353108: [libFuzzer][Windows] Clean up RawPrint (authored by metzman). · Explain WhyFeb 4 2019, 3:02 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 4 2019, 3:02 PM
Herald added subscribers: llvm-commits, delcypher. · View Herald Transcript

Revision Contents

PathSize
compiler-rt/
trunk/
lib/
fuzzer/
3 lines

Diff 185168

compiler-rt/trunk/lib/fuzzer/FuzzerIOWindows.cpp

Show First 20 Lines • Show All 327 Lines • ▼ Show 20 Linesbool IsInterestingCoverageFile(const std::string &FileName) {
if (FileName.find("compiler-rt\\lib\\") != std::string::npos) if (FileName.find("compiler-rt\\lib\\") != std::string::npos)
return false; // sanitizer internal. return false; // sanitizer internal.
if (FileName == "<null>") if (FileName == "<null>")
return false; return false;
return true; return true;
} }
void RawPrint(const char *Str) { void RawPrint(const char *Str) {
// Not tested, may or may not work. Fix if needed. _write(2, Str, strlen(Str));
write(2, Str, strlen(Str));
} }
} // namespace fuzzer } // namespace fuzzer
#endif // LIBFUZZER_WINDOWS #endif // LIBFUZZER_WINDOWS