This is an archive of the discontinued LLVM Phabricator instance.

Differential D57551

[libFuzzer][Windows] Temporarily disable value-profile-cmp2.test on Win
ClosedPublic

Authored by metzman on Jan 31 2019, 3:15 PM.

Details

Reviewers
morehouse
vitalybuka
Commits
rG6f94a033a7ed: [libFuzzer][Windows] Temporarily disable value-profile-cmp2.test on Win
rL352815: [libFuzzer][Windows] Temporarily disable value-profile-cmp2.test on Win
rCRT352815: [libFuzzer][Windows] Temporarily disable value-profile-cmp2.test on Win
Summary

Temporarily disable value-profile-cmp2.test on Win.
https://reviews.llvm.org/D57465 causes the test to fail on Win.
However, it seems that the behavior of libFuzzer on Win was broken
before that patch. It crashes in the exit handler when not used with
ASAN. Prior to the patch, the crash handler would run, tricking the
test into thinking libFuzzer on Win had exited properly.

Diff Detail

Event Timeline

metzman created this revision.Jan 31 2019, 3:15 PM
Harbormaster completed remote builds in B27574: Diff 184628.Jan 31 2019, 3:15 PM
metzman updated this revision to Diff 184629.Jan 31 2019, 3:16 PM
  • add comment
Harbormaster completed remote builds in B27575: Diff 184629.Jan 31 2019, 3:16 PM
metzman updated this revision to Diff 184630.Jan 31 2019, 3:17 PM
  • add comment
Harbormaster completed remote builds in B27576: Diff 184630.Jan 31 2019, 3:17 PM
metzman added reviewers: morehouse, vitalybuka.Jan 31 2019, 3:18 PM
metzman added a subscriber: yln.

Please take a look.

cc @yln

morehouse accepted this revision.Jan 31 2019, 3:20 PM

LGTM

This revision is now accepted and ready to land.Jan 31 2019, 3:20 PM
Closed by commit rCRT352815: [libFuzzer][Windows] Temporarily disable value-profile-cmp2.test on Win (authored by metzman). · Explain WhyJan 31 2019, 3:34 PM
This revision was automatically updated to reflect the committed changes.
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJan 31 2019, 3:34 PM

Revision Contents

PathSize
test/
fuzzer/
2 lines

Diff 184636

test/fuzzer/value-profile-cmp2.test

UNSUPPORTED: ios UNSUPPORTED: ios
FIXME: Make libFuzzer handle exits without ASan properly on Windows.
UNSUPPORTED: windows
CHECK: BINGO CHECK: BINGO
RUN: %cpp_compiler -fno-sanitize=address %S/SimpleHashTest.cpp -o %t-SimpleHashTest RUN: %cpp_compiler -fno-sanitize=address %S/SimpleHashTest.cpp -o %t-SimpleHashTest
RUN: not %run %t-SimpleHashTest -seed=1 -use_cmp=0 -use_value_profile=1 -runs=100000000 -max_len=64 2>&1 | FileCheck %s RUN: not %run %t-SimpleHashTest -seed=1 -use_cmp=0 -use_value_profile=1 -runs=100000000 -max_len=64 2>&1 | FileCheck %s