Page MenuHomePhabricator

[DWARF v5] A location description's length is a uleb not a short (Fixing PR40525).
ClosedPublic

Authored by wolfgangp on Jan 31 2019, 3:07 PM.

Details

Summary

PR40525 points out that we currently encode the length of location expressions with a short, which is correct for DWARF4 and earlier, but should be a uleb128 in DWARF5. This patch corrects this on both producer and consumer side.

Of the 3 modified test cases, 1 addresses the producer side and 2 the consumer side.

Diff Detail

Repository
rL LLVM

Event Timeline

wolfgangp created this revision.Jan 31 2019, 3:07 PM
wolfgangp retitled this revision from [DWARF v5] A location descriptionlength is a uleb not a short (Fixing PR40525). to [DWARF v5] A location description's length is a uleb not a short (Fixing PR40525)..Jan 31 2019, 3:13 PM
wolfgangp edited the summary of this revision. (Show Details)
wolfgangp added a subscriber: llvm-commits.
JDevlieghere accepted this revision.Jan 31 2019, 3:22 PM

LGTM, Thanks!

This revision is now accepted and ready to land.Jan 31 2019, 3:22 PM
davide accepted this revision.Jan 31 2019, 3:23 PM

LGTM

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 1 2019, 9:11 AM