This is an archive of the discontinued LLVM Phabricator instance.

Differential D57545

Fixed hasLinkerPrivateGlobalPrefix treating StringRef as C String.
ClosedPublic

Authored by aardappel on Jan 31 2019, 2:41 PM.

Details

Reviewers
jgravelle-google
sbc100
Commits
rG5f563f06d142: Fixed hasLinkerPrivateGlobalPrefix treating StringRef as C String.
rL352810: Fixed hasLinkerPrivateGlobalPrefix treating StringRef as C String.

Diff Detail

Event Timeline

aardappel created this revision.Jan 31 2019, 2:41 PM
Herald added subscribers: llvm-commits, aheejin. · View Herald TranscriptJan 31 2019, 2:41 PM
Harbormaster completed remote builds in B27571: Diff 184617.Jan 31 2019, 2:41 PM
sbc100 accepted this revision.Jan 31 2019, 2:42 PM
This revision is now accepted and ready to land.Jan 31 2019, 2:42 PM
Closed by commit rL352810: Fixed hasLinkerPrivateGlobalPrefix treating StringRef as C String. (authored by aardappel). · Explain WhyJan 31 2019, 3:03 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJan 31 2019, 3:03 PM

Revision Contents

PathSize
include/
llvm/
MC/
2 lines

Diff 184617

include/llvm/MC/MCAsmInfo.h

Show First 20 Lines • Show All 485 Lines • ▼ Show 20 Linespublic:
const char *getLabelSuffix() const { return LabelSuffix; } const char *getLabelSuffix() const { return LabelSuffix; }
bool useAssignmentForEHBegin() const { return UseAssignmentForEHBegin; } bool useAssignmentForEHBegin() const { return UseAssignmentForEHBegin; }
bool needsLocalForSize() const { return NeedsLocalForSize; } bool needsLocalForSize() const { return NeedsLocalForSize; }
StringRef getPrivateGlobalPrefix() const { return PrivateGlobalPrefix; } StringRef getPrivateGlobalPrefix() const { return PrivateGlobalPrefix; }
StringRef getPrivateLabelPrefix() const { return PrivateLabelPrefix; } StringRef getPrivateLabelPrefix() const { return PrivateLabelPrefix; }
bool hasLinkerPrivateGlobalPrefix() const { bool hasLinkerPrivateGlobalPrefix() const {
return LinkerPrivateGlobalPrefix[0] != '\0'; return !LinkerPrivateGlobalPrefix.empty();
} }
StringRef getLinkerPrivateGlobalPrefix() const { StringRef getLinkerPrivateGlobalPrefix() const {
if (hasLinkerPrivateGlobalPrefix()) if (hasLinkerPrivateGlobalPrefix())
return LinkerPrivateGlobalPrefix; return LinkerPrivateGlobalPrefix;
return getPrivateGlobalPrefix(); return getPrivateGlobalPrefix();
} }
▲ Show 20 Lines • Show All 139 Lines • Show Last 20 Lines