This is an archive of the discontinued LLVM Phabricator instance.

Fixed hasLinkerPrivateGlobalPrefix treating StringRef as C String.
ClosedPublic

Authored by aardappel on Jan 31 2019, 2:41 PM.

Reviewers

jgravelle-google
sbc100

Commits

This revision is now accepted and ready to land.Jan 31 2019, 2:42 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

llvm/

trunk/

include/

llvm/

MC/

2 lines

Show First 20 Lines • Show All 485 Lines • ▼ Show 20 Lines	public:
const char *getLabelSuffix() const { return LabelSuffix; }		const char *getLabelSuffix() const { return LabelSuffix; }

bool useAssignmentForEHBegin() const { return UseAssignmentForEHBegin; }		bool useAssignmentForEHBegin() const { return UseAssignmentForEHBegin; }
bool needsLocalForSize() const { return NeedsLocalForSize; }		bool needsLocalForSize() const { return NeedsLocalForSize; }
StringRef getPrivateGlobalPrefix() const { return PrivateGlobalPrefix; }		StringRef getPrivateGlobalPrefix() const { return PrivateGlobalPrefix; }
StringRef getPrivateLabelPrefix() const { return PrivateLabelPrefix; }		StringRef getPrivateLabelPrefix() const { return PrivateLabelPrefix; }

bool hasLinkerPrivateGlobalPrefix() const {		bool hasLinkerPrivateGlobalPrefix() const {
return LinkerPrivateGlobalPrefix[0] != '\0';		return !LinkerPrivateGlobalPrefix.empty();
}		}

StringRef getLinkerPrivateGlobalPrefix() const {		StringRef getLinkerPrivateGlobalPrefix() const {
if (hasLinkerPrivateGlobalPrefix())		if (hasLinkerPrivateGlobalPrefix())
return LinkerPrivateGlobalPrefix;		return LinkerPrivateGlobalPrefix;
return getPrivateGlobalPrefix();		return getPrivateGlobalPrefix();
}		}

▲ Show 20 Lines • Show All 139 Lines • Show Last 20 Lines