[tools] Fix python DeprecationWarning: invalid escape sequence

[MarcoFalke]

Summary

The python documentation says "it’s highly recommended that you use raw strings for all but the simplest expressions." (https://docs.python.org/3/library/re.html)

So do that with the attached patch generated by

sed -i -e "s/re.search('/re.search(r'/g" $(git grep -l 're.search(')

The warning can be seen in e.g. python3.7:

$ python3.7 -Wd
>>> import re; re.search('\s', '')
<stdin>:1: DeprecationWarning: invalid escape sequence \s

[serge-sans-paille]

LGTM, do you have commit right?

[MarcoFalke]

No, I don't have commit right

[serge-sans-paille]

@MarcoFalke it's in, thanks for the patch o/

tools/clang-format/clang-format-diff.py

def main():
   parser.add_argument('-binary', default='clang-format',
                       help='location of binary to use for clang-format')
   args = parser.parse_args()
 
   # Extract changed lines for each file.
   filename = None
   lines_by_file = {}
   for line in sys.stdin:
-    match = re.search('^\+\+\+\ (.*?/){%s}(\S*)' % args.p, line)
+    match = re.search(r'^\+\+\+\ (.*?/){%s}(\S*)' % args.p, line)
     if match:
       filename = match.group(2)
     if filename == None:
       continue
 
     if args.regex is not None:
       if not re.match('^%s$' % args.regex, filename):
         continue
     else:
       if not re.match('^%s$' % args.iregex, filename, re.IGNORECASE):
         continue
 
-    match = re.search('^@@.*\+(\d+)(,(\d+))?', line)
+    match = re.search(r'^@@.*\+(\d+)(,(\d+))?', line)
     if match:
       start_line = int(match.group(1))
       line_count = 1
       if match.group(3):
         line_count = int(match.group(3))
       if line_count == 0:
         continue
       end_line = start_line + line_count - 1

tools/scan-build-py/libscanbuild/analyze.py

def need_analyzer(args):
 
     When static analyzer run against project configure step, it should be
     silent and no need to run the analyzer or generate report.
 
     To run `scan-build` against the configure step might be necessary,
     when compiler wrappers are used. That's the moment when build setup
     check the compiler and capture the location for the build process. """
 
-    return len(args) and not re.search('configure|autogen', args[0])
+    return len(args) and not re.search(r'configure|autogen', args[0])
 
 
 def prefix_with(constant, pieces):
     """ From a sequence create another sequence where every second element
     is from the original sequence and the odd elements are the prefix.
 
     eg.: prefix_with(0, [1,2,3]) creates [0, 1, 0, 2, 0, 3] """
 

tools/scan-build/bin/set-xcode-analyzer

if isBuiltinAnalyzer:
             pathToChecker = "$(CLANG_ANALYZER_EXEC)"
             break
     # Now create a new file.
     for line in f:
       if not foundAnalyzer:
         if line.find("Static Analyzer") >= 0:
           foundAnalyzer = True
       else:
-        m = re.search('^(\s*ExecPath\s*=\s*")', line)
+        m = re.search(r'^(\s*ExecPath\s*=\s*")', line)
         if m:
           line = "".join([m.group(0), pathToChecker, '";\n'])
           # Do not modify further ExecPath's later in the xcspec.
           foundAnalyzer = False
       t.write(line)
   t.close()
   print "(+) processing:", path
   try: