User Details
User Details
- User Since
- Jun 12 2018, 2:03 PM (276 w, 1 d)
Jul 28 2023
Jul 28 2023
MarcoFalke committed rG52526065bc80: [NFC][compiler-rt] Add missing space in libfuzzer -help docs (authored by MarcoFalke).
[NFC][compiler-rt] Add missing space in libfuzzer -help docs
Jul 17 2023
Jul 17 2023
MarcoFalke added a comment to D155206: [compiler-rt][NFC] Avoid implicit-integer-sign-change in FuzzedDataProvider::ConsumeIntegralInRange.
I went ahead and merged this, because it should be trivially correct. Feel free to revert or let me know if there are any issues.
MarcoFalke committed rGfa8401f9bfe8: [compiler-rt][NFC] Avoid implicit-integer-sign-change in FuzzedDataProvider… (authored by MarcoFalke).
[compiler-rt][NFC] Avoid implicit-integer-sign-change in FuzzedDataProvider…
Jul 13 2023
Jul 13 2023
MarcoFalke updated the diff for D155206: [compiler-rt][NFC] Avoid implicit-integer-sign-change in FuzzedDataProvider::ConsumeIntegralInRange.
Fix both places
Mar 23 2023
Mar 23 2023
MarcoFalke committed rG8c10256734cd: clang-tidy: Detect use-after-move in CXXCtorInitializer (authored by MarcoFalke).
clang-tidy: Detect use-after-move in CXXCtorInitializer
Mar 22 2023
Mar 22 2023
MarcoFalke added a comment to D146288: clang-tidy: Detect use-after-move in CXXCtorInitializer.
Minor NFC, I plan to land this tomorrow or Friday
MarcoFalke updated the diff for D146288: clang-tidy: Detect use-after-move in CXXCtorInitializer.
NFC
Mar 20 2023
Mar 20 2023
MarcoFalke added a comment to D146288: clang-tidy: Detect use-after-move in CXXCtorInitializer.
Thanks, addressed some more review comments.
MarcoFalke updated the diff for D146288: clang-tidy: Detect use-after-move in CXXCtorInitializer.
address feedback about matcher, clang-format
MarcoFalke added inline comments to D146288: clang-tidy: Detect use-after-move in CXXCtorInitializer.
MarcoFalke updated the diff for D146288: clang-tidy: Detect use-after-move in CXXCtorInitializer.
Took some review suggestions (Thanks!)
Mar 17 2023
Mar 17 2023
MarcoFalke updated the diff for D146288: clang-tidy: Detect use-after-move in CXXCtorInitializer.
sort doc
MarcoFalke updated the diff for D146288: clang-tidy: Detect use-after-move in CXXCtorInitializer.
clang-format+doc
MarcoFalke requested review of D146288: clang-tidy: Detect use-after-move in CXXCtorInitializer.
Mar 6 2023
Mar 6 2023
MarcoFalke committed rGfa491fefb0f8: clang-tidy: Count template constructors in modernize-use-default-member-init (authored by MarcoFalke).
clang-tidy: Count template constructors in modernize-use-default-member-init
Mar 2 2023
Mar 2 2023
MarcoFalke updated the diff for D143375: clang-tidy: Count template constructors in modernize-use-default-member-init.
mv release note, rebase
Feb 27 2023
Feb 27 2023
MarcoFalke updated the diff for D143375: clang-tidy: Count template constructors in modernize-use-default-member-init.
Thanks. Added release note. Lmk if I should go ahead and merge this.
Feb 10 2023
Feb 10 2023
Feb 9 2023
Feb 9 2023
MarcoFalke updated the diff for D143375: clang-tidy: Count template constructors in modernize-use-default-member-init.
Remove both test cases that pass on current main on Linux, but fail on Windows. Seems unrelated to add/fix them here.
MarcoFalke updated the diff for D143375: clang-tidy: Count template constructors in modernize-use-default-member-init.
Simplify patch and remove test case failing on Windows, but passing on Linux
Feb 6 2023
Feb 6 2023
Jan 25 2023
Jan 25 2023
MarcoFalke committed rG007b35369501: doc: Fix typo in clang-tidy no-automatic-move doc (authored by MarcoFalke).
doc: Fix typo in clang-tidy no-automatic-move doc
Nov 10 2021
Nov 10 2021
MarcoFalke committed rGfa1729067c74: [compiler-rt] Fix typo in DeadlockDetector (chanding->changing) (authored by MarcoFalke).
[compiler-rt] Fix typo in DeadlockDetector (chanding->changing)
MarcoFalke committed rGfaa019c0e38e: [libc++] Fix segmentation fault in __do_put_integral (authored by MarcoFalke).
[libc++] Fix segmentation fault in __do_put_integral
Nov 10 2021, 12:26 PM · Restricted Project
MarcoFalke added a comment to D113600: [libc++] Fix segmentation fault in __do_put_integral.
There are tests, but the issue (segmentation fault) is only observable on 32-bit AFAICT. On other platforms it is "only" UB, but doing the right thing.
Nov 10 2021, 12:15 PM · Restricted Project
MarcoFalke requested review of D113600: [libc++] Fix segmentation fault in __do_put_integral.
Nov 10 2021, 11:51 AM · Restricted Project
May 23 2021
May 23 2021
MarcoFalke added a comment to D97572: [libc++] Include <__config_site> from <__config>.
I suspect this broke the OSS-Fuzz integration
May 23 2021, 3:08 AM · Restricted Project, Restricted Project, Unknown Object (Project), Restricted Project
Mar 9 2021
Mar 9 2021
MarcoFalke added a comment to D98057: [compiler-rt] FuzzedDataProvider: Add missing include.
I merged this before review because without the patch we are unable to compile and it should be trivially correct. Feel free to revert if there are any issues with it.
Mar 9 2021, 3:28 AM · Unknown Object (Project)
MarcoFalke committed rG0cccccf0d2cb: [compiler-rt] FuzzedDataProvider: Add missing include (authored by MarcoFalke).
[compiler-rt] FuzzedDataProvider: Add missing include
Mar 9 2021, 3:27 AM · Unknown Object (Project)
Mar 5 2021
Mar 5 2021
MarcoFalke added a reviewer for D98057: [compiler-rt] FuzzedDataProvider: Add missing include: Dor1s.
Mar 5 2021, 10:01 AM · Unknown Object (Project)
MarcoFalke updated subscribers of D98057: [compiler-rt] FuzzedDataProvider: Add missing include.
@Dor1s I can commit this myself, but it needs one approval first. Mind taking a look?
Mar 5 2021, 10:01 AM · Unknown Object (Project)
MarcoFalke set the repository for D98057: [compiler-rt] FuzzedDataProvider: Add missing include to rG LLVM Github Monorepo.
Mar 5 2021, 9:59 AM · Unknown Object (Project)
MarcoFalke requested review of D98057: [compiler-rt] FuzzedDataProvider: Add missing include.
Mar 5 2021, 9:57 AM · Unknown Object (Project)
Dec 17 2020
Dec 17 2020
MarcoFalke updated the summary of D93412: [compiler-rt] FuzzedDataProvider: Add PickValueInArray for std::array.
Dec 17 2020, 2:38 AM · Unknown Object (Project)
MarcoFalke added a comment to D93412: [compiler-rt] FuzzedDataProvider: Add PickValueInArray for std::array.
Yes, please. I don't have commit right.
Dec 17 2020, 2:26 AM · Unknown Object (Project)
Dec 16 2020
Dec 16 2020
MarcoFalke added a reviewer for D93412: [compiler-rt] FuzzedDataProvider: Add PickValueInArray for std::array: Dor1s.
Dec 16 2020, 10:15 PM · Unknown Object (Project)
MarcoFalke updated the diff for D93412: [compiler-rt] FuzzedDataProvider: Add PickValueInArray for std::array.
Made unit test pass 😅
Dec 16 2020, 11:25 AM · Unknown Object (Project)
MarcoFalke requested review of D93412: [compiler-rt] FuzzedDataProvider: Add PickValueInArray for std::array.
Dec 16 2020, 11:09 AM · Unknown Object (Project)
Apr 18 2020
Apr 18 2020
Apr 18 2020, 10:45 AM · Unknown Object (Project)
Apr 15 2020
Apr 15 2020
Apr 15 2020, 2:55 PM · Unknown Object (Project)
Feb 11 2019
Feb 11 2019
MarcoFalke added a comment to D57528: [tools] Fix python DeprecationWarning: invalid escape sequence.
No, I don't have commit right
Jan 31 2019
Jan 31 2019
Jul 29 2018
Jul 29 2018
MarcoFalke added a comment to D48098: clang-format-diff: Make it work with python3 too.
Jun 26 2018
Jun 26 2018
MarcoFalke updated the diff for D48098: clang-format-diff: Make it work with python3 too.
Keep python2 by default for now
Jun 13 2018
Jun 13 2018
MarcoFalke updated the summary of D48098: clang-format-diff: Make it work with python3 too.
MarcoFalke updated the summary of D48098: clang-format-diff: Make it work with python3 too.
MarcoFalke updated the diff for D48098: clang-format-diff: Make it work with python3 too.
MarcoFalke added a comment to D48098: clang-format-diff: Make it work with python3 too.
why is this switch necessary?
Jun 12 2018
Jun 12 2018
MarcoFalke updated the diff for D48098: clang-format-diff: Make it work with python3 too.
In python2.7:
TypeError: 'encoding' is an invalid keyword argument for this function