Page MenuHomePhabricator

[CUDA] Propagate detected version of CUDA to cc1
ClosedPublic

Authored by tra on Jan 30 2019, 4:32 PM.

Details

Summary

..and use it to control that parts of CUDA compilation
that depend on the specific version of CUDA SDK.

This patch has a placeholder for a 'new launch API' support
which is in a separate patch (D57488).
The list will be further extended in the upcoming patch to support CUDA-10.1.

Diff Detail

Repository
rL LLVM

Event Timeline

tra created this revision.Jan 30 2019, 4:32 PM
tra updated this revision to Diff 184412.Jan 30 2019, 4:51 PM

Updated the comment about SDKVersion use.

jlebar accepted this revision.Jan 30 2019, 4:55 PM
jlebar added inline comments.
clang/include/clang/Basic/Cuda.h
108 ↗(On Diff #184412)

Should this enum be documented?

clang/lib/Driver/ToolChains/Clang.cpp
3475 ↗(On Diff #184412)

nit, s/as/, as/

This revision is now accepted and ready to land.Jan 30 2019, 4:55 PM
tra updated this revision to Diff 184416.Jan 30 2019, 5:12 PM

Addressed Justin's comments.

tra marked 2 inline comments as done.Jan 30 2019, 5:12 PM
This revision was automatically updated to reflect the committed changes.