[CMake] Accept ENTITLEMENTS in llvm_add_library()
ClosedPublic
Actions

Authored by sgraenitz on Jan 28 2019, 8:41 AM.

Details

Reviewers

beanz
bogner

Commits

rG19c598746186: [CMake] Accept ENTITLEMENTS in llvm_add_library()
rL352628: [CMake] Accept ENTITLEMENTS in llvm_add_library()

Summary

We added support for code signing entitlements in add_llvm_executable() with D54443. In the future it would be useful to have this functionality available also for libraries.

Diff Detail

Repository: rL LLVM

Event Timeline

sgraenitz created this revision.Jan 28 2019, 8:41 AM

Herald added subscribers: llvm-commits, mgorny. · View Herald TranscriptJan 28 2019, 8:41 AM

Harbormaster completed remote builds in B27395: Diff 183874.Jan 28 2019, 8:41 AM

sgraenitz mentioned this in D57378: [CMake] Accept entitlements for code signing in add_lldb_library().Jan 29 2019, 3:34 AM

sgraenitz added a reviewer: bogner.Jan 29 2019, 3:46 AM

Tested this with LLDB library target.

LGTM

This revision is now accepted and ready to land.Jan 29 2019, 11:59 AM

Closed by commit rL352628: [CMake] Accept ENTITLEMENTS in llvm_add_library() (authored by stefan.graenitz, committed by ). · Explain WhyJan 30 2019, 7:10 AM

This revision was automatically updated to reflect the committed changes.

Diffusion mentioned this in rL352629: [CMake] Accept entitlements for code signing in add_lldb_library().Jan 30 2019, 7:13 AM

Diffusion mentioned this in rLLDB352629: [CMake] Accept entitlements for code signing in add_lldb_library().

Revision Contents
Changeset List

			Path	Packages
M			llvm/trunk/cmake/modules/AddLLVM.cmake (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	183874	352366		Jan 28 2019, 8:41 AM	★	★
Diff 2	184291	352627	rL352628	Jan 30 2019, 7:10 AM	★	★

Diff 184291

View Options

llvm/trunk/cmake/modules/AddLLVM.cmake

[CMake] Accept ENTITLEMENTS in llvm_add_library()ClosedPublicActions