Page MenuHomePhabricator

[CMake] Quick-Fix FileCheck target does not exist when building against LLVM install-tree with COMPILER_RT_INCLUDE_TESTS=ON
ClosedPublic

Authored by sgraenitz on Jan 25 2019, 3:01 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

sgraenitz created this revision.Jan 25 2019, 3:01 AM
Herald added a subscriber: Restricted Project. · View Herald TranscriptJan 25 2019, 3:01 AM
mgorny accepted this revision.Jan 25 2019, 3:35 AM

Can't call that a really proper fix but I guess it's good enough for me. As for running tests, it's non trivial, so I'll try them later using our ebuilds.

This revision is now accepted and ready to land.Jan 25 2019, 3:35 AM
sgraenitz retitled this revision from [CMake] Fix FileCheck target does not exist when building against LLVM install-tree with COMPILER_RT_INCLUDE_TESTS=ON to [CMake] Quick-Fix FileCheck target does not exist when building against LLVM install-tree with COMPILER_RT_INCLUDE_TESTS=ON.Jan 25 2019, 4:37 AM
sgraenitz edited the summary of this revision. (Show Details)

(I've also tested the patch now and everything works as expected now)

Hah, I had the exact same fix on our private branch.

I think this might create problems if you generate files from cmake and immediately run ninja check-sanitizer (without building the rest of llvm). Can you check if that works? If so, it's an LGTM.

Thank you,
Filipe

Hah, I had the exact same fix on our private branch.

I think this might create problems if you generate files from cmake and immediately run ninja check-sanitizer (without building the rest of llvm). Can you check if that works? If so, it's an LGTM.

if you are concerned about dependencies in non-standalone builds, they are handled separately from this. This addition was only done for COMPILER_RT_STANDALONE_BUILD.

filcab accepted this revision.Jan 25 2019, 7:32 AM

if you are concerned about dependencies in non-standalone builds, they are handled separately from this. This addition was only done for COMPILER_RT_STANDALONE_BUILD.

Right. Then LGTM.

This revision was automatically updated to reflect the committed changes.
delcypher added inline comments.Jan 28 2019, 8:47 AM
compiler-rt/trunk/test/CMakeLists.txt
17

Rather than deleting these lines, would this be more sensible?

if (NOT COMPILER_RT_STANDALONE_BUILD)
  list(APPEND SANITIZER_COMMON_LIT_TEST_DEPS FileCheck)
endif()