Page MenuHomePhabricator

Fix compatibility with the msvc AI compiler option
ClosedPublic

Authored by rnk on Jan 24 2019, 1:46 PM.

Details

Summary

The unsupported /AI option accepts directory paths in a manner similar to the supported /I option and allows spaces between the flag and the directory. An example snippet from our production compile that broke on clang-cl.exe because it read the path as an input file.

/AI %WindowsSdkDir%\References\%WindowsSDKVersion% /I %WindowsSdkDir%\Include\%WindowsSDKVersion%\winrt

Diff Detail

Repository
rL LLVM

Event Timeline

zahen created this revision.Jan 24 2019, 1:46 PM
rnk accepted this revision.Jan 24 2019, 2:07 PM

lgtm, I'll go ahead and commit this soon.

This revision is now accepted and ready to land.Jan 24 2019, 2:07 PM
rnk commandeered this revision.Jan 24 2019, 2:16 PM
rnk edited reviewers, added: zahen; removed: rnk.
This revision now requires review to proceed.Jan 24 2019, 2:16 PM
rnk updated this revision to Diff 183398.Jan 24 2019, 2:18 PM
  • add test
This revision was not accepted when it landed; it landed in state Needs Review.Jan 24 2019, 2:26 PM
Closed by commit rL352119: [clang-cl] Ignore space-separated /AI arguments (authored by rnk, committed by ). · Explain Why
This revision was automatically updated to reflect the committed changes.