This is an archive of the discontinued LLVM Phabricator instance.

Differential D57043

[clangd] Use the shared forced-linking code.
Needs ReviewPublic

Authored by hokein on Jan 22 2019, 1:58 AM.

Details

Reviewers
sammccall
Summary

Also add a missing MPI module.

Diff Detail

Event Timeline

hokein created this revision.Jan 22 2019, 1:58 AM
Herald added subscribers: kadircet, arphaman, jkorous and 5 others. · View Herald TranscriptJan 22 2019, 1:58 AM
Harbormaster completed remote builds in B27148: Diff 182864.Jan 22 2019, 1:59 AM
sammccall added inline comments.Jan 22 2019, 4:31 AM
clangd/CMakeLists.txt
110

clangd doesn't support the static analyzer.
Fundamentally I don't know how to enforce the partial-traversal (needed for performance).

Revision Contents

PathSize
clangd/
6 lines
27 lines

Diff 182864

clangd/CMakeLists.txt

Show First 20 Lines • Show All 101 Lines • ▼ Show 20 Linesadd_clang_library(clangDaemon
clangTooling clangTooling
clangToolingCore clangToolingCore
clangToolingInclusions clangToolingInclusions
clangToolingRefactor clangToolingRefactor
${LLVM_PTHREAD_LIB} ${LLVM_PTHREAD_LIB}
${CLANGD_ATOMIC_LIB} ${CLANGD_ATOMIC_LIB}
) )
if( CLANG_ENABLE_STATIC_ANALYZER )
sammccallUnsubmitted
Not Done
ReplyInline Actions

clangd doesn't support the static analyzer.
Fundamentally I don't know how to enforce the partial-traversal (needed for performance).

sammccall: clangd doesn't support the static analyzer. Fundamentally I don't know how to enforce the…
target_link_libraries(clangDaemon PRIVATE
clangTidyMPIModule
)
endif()
if( LLVM_LIB_FUZZING_ENGINE OR LLVM_USE_SANITIZE_COVERAGE ) if( LLVM_LIB_FUZZING_ENGINE OR LLVM_USE_SANITIZE_COVERAGE )
add_subdirectory(fuzzer) add_subdirectory(fuzzer)
endif() endif()
add_subdirectory(tool) add_subdirectory(tool)
add_subdirectory(indexer) add_subdirectory(indexer)
add_subdirectory(index/dex/dexp) add_subdirectory(index/dex/dexp)
if (LLVM_INCLUDE_BENCHMARKS) if (LLVM_INCLUDE_BENCHMARKS)
add_subdirectory(benchmarks) add_subdirectory(benchmarks)
endif() endif()
if ( CLANGD_BUILD_XPC ) if ( CLANGD_BUILD_XPC )
add_subdirectory(xpc) add_subdirectory(xpc)
endif () endif ()

clangd/ClangdUnit.cpp

Show First 20 Lines • Show All 566 Lines • ▼ Show 20 LinesSourceLocation getBeginningOfIdentifier(ParsedAST &Unit, const Position &Pos,
if (Before.isValid() && if (Before.isValid() &&
!Lexer::getRawToken(Before, Tok, SourceMgr, AST.getLangOpts(), false) && !Lexer::getRawToken(Before, Tok, SourceMgr, AST.getLangOpts(), false) &&
Tok.is(tok::raw_identifier)) Tok.is(tok::raw_identifier))
return SourceMgr.getMacroArgExpandedLocation(Before); // Case 2. return SourceMgr.getMacroArgExpandedLocation(Before); // Case 2.
return SourceMgr.getMacroArgExpandedLocation(InputLoc); // Case 1 or 3. return SourceMgr.getMacroArgExpandedLocation(InputLoc); // Case 1 or 3.
} }
} // namespace clangd } // namespace clangd
namespace tidy {
// Force the linker to link in Clang-tidy modules.
#define LINK_TIDY_MODULE(X) \
extern volatile int X##ModuleAnchorSource; \
static int LLVM_ATTRIBUTE_UNUSED X##ModuleAnchorDestination = \
X##ModuleAnchorSource
LINK_TIDY_MODULE(CERT);
LINK_TIDY_MODULE(Abseil);
LINK_TIDY_MODULE(Boost);
LINK_TIDY_MODULE(Bugprone);
LINK_TIDY_MODULE(LLVM);
LINK_TIDY_MODULE(CppCoreGuidelines);
LINK_TIDY_MODULE(Fuchsia);
LINK_TIDY_MODULE(Google);
LINK_TIDY_MODULE(Android);
LINK_TIDY_MODULE(Misc);
LINK_TIDY_MODULE(Modernize);
LINK_TIDY_MODULE(Performance);
LINK_TIDY_MODULE(Portability);
LINK_TIDY_MODULE(Readability);
LINK_TIDY_MODULE(ObjC);
LINK_TIDY_MODULE(HICPP);
LINK_TIDY_MODULE(Zircon);
#undef LINK_TIDY_MODULE
} // namespace tidy
} // namespace clang } // namespace clang
#include "../clang-tidy/ClangTidyForceLinker.h"
No newline at end of file