This is an archive of the discontinued LLVM Phabricator instance.

Differential D56972

[CMake][Fuchsia] Drop -DNDEBUG, re-enable modules
ClosedPublic

Authored by phosek on Jan 19 2019, 8:21 PM.

Details

Reviewers
mcgrathr
jakehehrlich
juliehockett
Commits
rG6d58c9e2b29c: [CMake][Fuchsia] Drop -DNDEBUG, re-enable modules
rC351709: [CMake][Fuchsia] Drop -DNDEBUG, re-enable modules
rL351709: [CMake][Fuchsia] Drop -DNDEBUG, re-enable modules
Summary

-DNDEBUG is no longer needed now that we don't enable assertions, modules should improve build times for the second stage.

Diff Detail

Repository
rL LLVM

Event Timeline

phosek created this revision.Jan 19 2019, 8:21 PM
Herald added subscribers: cfe-commits, mgorny. · View Herald TranscriptJan 19 2019, 8:21 PM
mcgrathr accepted this revision.Jan 20 2019, 5:01 PM

lgtm

This revision is now accepted and ready to land.Jan 20 2019, 5:01 PM
Closed by commit rL351709: [CMake][Fuchsia] Drop -DNDEBUG, re-enable modules (authored by phosek). · Explain WhyJan 20 2019, 5:07 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptJan 20 2019, 5:07 PM

Revision Contents

PathSize
cfe/
trunk/
cmake/
caches/
5 lines

Diff 182728

cfe/trunk/cmake/caches/Fuchsia-stage2.cmake

# This file sets up a CMakeCache for the second stage of a Fuchsia toolchain build. # This file sets up a CMakeCache for the second stage of a Fuchsia toolchain build.
set(LLVM_TARGETS_TO_BUILD X86;ARM;AArch64 CACHE STRING "") set(LLVM_TARGETS_TO_BUILD X86;ARM;AArch64 CACHE STRING "")
set(PACKAGE_VENDOR Fuchsia CACHE STRING "") set(PACKAGE_VENDOR Fuchsia CACHE STRING "")
set(LLVM_ENABLE_BACKTRACES OFF CACHE BOOL "") set(LLVM_ENABLE_BACKTRACES OFF CACHE BOOL "")
if(NOT APPLE) if(NOT APPLE)
set(LLVM_ENABLE_LLD ON CACHE BOOL "") set(LLVM_ENABLE_LLD ON CACHE BOOL "")
endif() endif()
set(LLVM_ENABLE_LTO ON CACHE BOOL "") set(LLVM_ENABLE_LTO ON CACHE BOOL "")
set(LLVM_ENABLE_MODULES ON CACHE BOOL "")
set(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR ON CACHE BOOL "") set(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR ON CACHE BOOL "")
set(LLVM_ENABLE_TERMINFO OFF CACHE BOOL "") set(LLVM_ENABLE_TERMINFO OFF CACHE BOOL "")
set(LLVM_ENABLE_ZLIB ON CACHE BOOL "") set(LLVM_ENABLE_ZLIB ON CACHE BOOL "")
set(LLVM_EXTERNALIZE_DEBUGINFO ON CACHE BOOL "") set(LLVM_EXTERNALIZE_DEBUGINFO ON CACHE BOOL "")
set(LLVM_INCLUDE_EXAMPLES OFF CACHE BOOL "") set(LLVM_INCLUDE_EXAMPLES OFF CACHE BOOL "")
set(LLVM_INCLUDE_DOCS OFF CACHE BOOL "") set(LLVM_INCLUDE_DOCS OFF CACHE BOOL "")
set(CLANG_DEFAULT_CXX_STDLIB libc++ CACHE STRING "") set(CLANG_DEFAULT_CXX_STDLIB libc++ CACHE STRING "")
if(NOT APPLE) if(NOT APPLE)
set(CLANG_DEFAULT_LINKER lld CACHE STRING "") set(CLANG_DEFAULT_LINKER lld CACHE STRING "")
set(CLANG_DEFAULT_OBJCOPY llvm-objcopy CACHE STRING "") set(CLANG_DEFAULT_OBJCOPY llvm-objcopy CACHE STRING "")
endif() endif()
set(CLANG_DEFAULT_RTLIB compiler-rt CACHE STRING "") set(CLANG_DEFAULT_RTLIB compiler-rt CACHE STRING "")
set(CLANG_PLUGIN_SUPPORT OFF CACHE BOOL "") set(CLANG_PLUGIN_SUPPORT OFF CACHE BOOL "")
set(ENABLE_LINKER_BUILD_ID ON CACHE BOOL "") set(ENABLE_LINKER_BUILD_ID ON CACHE BOOL "")
set(ENABLE_X86_RELAX_RELOCATIONS ON CACHE BOOL "") set(ENABLE_X86_RELAX_RELOCATIONS ON CACHE BOOL "")
set(CMAKE_BUILD_TYPE RelWithDebInfo CACHE STRING "") set(CMAKE_BUILD_TYPE RelWithDebInfo CACHE STRING "")
set(CMAKE_C_FLAGS_RELWITHDEBINFO "-O3 -gline-tables-only -DNDEBUG" CACHE STRING "") set(CMAKE_C_FLAGS_RELWITHDEBINFO "-O3 -gline-tables-only" CACHE STRING "")
set(CMAKE_CXX_FLAGS_RELWITHDEBINFO "-O3 -gline-tables-only -DNDEBUG" CACHE STRING "") set(CMAKE_CXX_FLAGS_RELWITHDEBINFO "-O3 -gline-tables-only" CACHE STRING "")
if(APPLE) if(APPLE)
list(APPEND BUILTIN_TARGETS "default") list(APPEND BUILTIN_TARGETS "default")
list(APPEND RUNTIME_TARGETS "default") list(APPEND RUNTIME_TARGETS "default")
set(COMPILER_RT_ENABLE_IOS OFF CACHE BOOL "") set(COMPILER_RT_ENABLE_IOS OFF CACHE BOOL "")
set(COMPILER_RT_ENABLE_TVOS OFF CACHE BOOL "") set(COMPILER_RT_ENABLE_TVOS OFF CACHE BOOL "")
set(COMPILER_RT_ENABLE_WATCHOS OFF CACHE BOOL "") set(COMPILER_RT_ENABLE_WATCHOS OFF CACHE BOOL "")
▲ Show 20 Lines • Show All 138 Lines • Show Last 20 Lines