This is an archive of the discontinued LLVM Phabricator instance.

Thread safety analysis: Improve diagnostics for double locking
ClosedPublic

Authored by aaronpuchert on Jan 19 2019, 2:47 PM.

Diff Detail

Event Timeline

aaronpuchert created this revision.Jan 19 2019, 2:47 PM
aaron.ballman accepted this revision.Jan 21 2019, 11:26 AM

LGTM aside from a naming convention nit.

lib/Analysis/ThreadSafety.cpp
984

fact -> Fact

This revision is now accepted and ready to land.Jan 21 2019, 11:26 AM
aaronpuchert marked 2 inline comments as done.Jan 21 2019, 2:28 PM

Thanks for the review! I'll commit this when I have commit access again, which is waiting for my employer's approval to the relicensing.

lib/Sema/AnalysisBasedWarnings.cpp
1693

I'll assume it's also Notes then. I tend to subconsciously forget these things.

Thanks for the review! I'll commit this when I have commit access again, which is waiting for my employer's approval to the relicensing.

Sounds good to me!

lib/Sema/AnalysisBasedWarnings.cpp
1693

Yup, my eyes missed that one, so thank you for catching it.

This revision was automatically updated to reflect the committed changes.