This is an archive of the discontinued LLVM Phabricator instance.

Differential D56895

AMDGPU: Legalize more bitcasts
ClosedPublic

Authored by arsenm on Jan 17 2019, 6:53 PM.

Details

Reviewers
tstellar
rampitec

Diff Detail

Event Timeline

arsenm created this revision.Jan 17 2019, 6:53 PM
Herald added subscribers: t-tye, tpr, dstuttard and 5 others. · View Herald TranscriptJan 17 2019, 6:54 PM
tstellar accepted this revision.Jan 17 2019, 6:57 PM

LGTM.

This revision is now accepted and ready to land.Jan 17 2019, 6:57 PM
arsenm closed this revision.Jan 20 2019, 11:45 AM

r351700

Revision Contents

PathSize
lib/
Target/
AMDGPU/
11 lines
test/
CodeGen/
AMDGPU/
GlobalISel/
174 lines

Diff 182437

lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp

Show First 20 Lines • Show All 106 Lines • ▼ Show 20 LinesAMDGPULegalizerInfo::AMDGPULegalizerInfo(const GCNSubtarget &ST,
getActionDefinitionsBuilder({G_AND, G_OR, G_XOR}) getActionDefinitionsBuilder({G_AND, G_OR, G_XOR})
.legalFor({S32, S1, S64, V2S32}) .legalFor({S32, S1, S64, V2S32})
.clampScalar(0, S32, S64); .clampScalar(0, S32, S64);
getActionDefinitionsBuilder({G_UADDO, G_SADDO, G_USUBO, G_SSUBO, getActionDefinitionsBuilder({G_UADDO, G_SADDO, G_USUBO, G_SSUBO,
G_UADDE, G_SADDE, G_USUBE, G_SSUBE}) G_UADDE, G_SADDE, G_USUBE, G_SSUBE})
.legalFor({{S32, S1}}); .legalFor({{S32, S1}});
setAction({G_BITCAST, V2S16}, Legal); getActionDefinitionsBuilder(G_BITCAST)
setAction({G_BITCAST, 1, S32}, Legal); .legalForCartesianProduct({S32, V2S16})
.legalForCartesianProduct({S64, V2S32, V4S16})
setAction({G_BITCAST, S32}, Legal); .legalForCartesianProduct({V2S64, V4S32})
setAction({G_BITCAST, 1, V2S16}, Legal); // Don't worry about the size constraint.
.legalIf(all(isPointer(0), isPointer(1)));
getActionDefinitionsBuilder(G_FCONSTANT) getActionDefinitionsBuilder(G_FCONSTANT)
.legalFor({S32, S64, S16}); .legalFor({S32, S64, S16});
// G_IMPLICIT_DEF is a no-op so we can make it legal for any value type that // G_IMPLICIT_DEF is a no-op so we can make it legal for any value type that
// can fit in a register. // can fit in a register.
// FIXME: We need to legalize several more operations before we can add // FIXME: We need to legalize several more operations before we can add
// a test case for size > 512. // a test case for size > 512.
▲ Show 20 Lines • Show All 336 Lines • Show Last 20 Lines

test/CodeGen/AMDGPU/GlobalISel/legalize-bitcast.mir

# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py # NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
# RUN: llc -mtriple=amdgcn-mesa-mesa3d -mcpu=fiji -run-pass=legalizer %s -o - | FileCheck %s # RUN: llc -mtriple=amdgcn-mesa-mesa3d -mcpu=fiji -run-pass=legalizer %s -o - | FileCheck %s
--- ---
name: test_bitcast name: test_bitcast_s32_to_v2s16
body: | body: |
bb.0: bb.0:
liveins: $vgpr0 liveins: $vgpr0
; CHECK-LABEL: name: test_bitcast ; CHECK-LABEL: name: test_bitcast_s32_to_v2s16
; CHECK: [[COPY:%[0-9]+]]:_(s32) = COPY $vgpr0 ; CHECK: [[COPY:%[0-9]+]]:_(s32) = COPY $vgpr0
; CHECK: [[BITCAST:%[0-9]+]]:_(<2 x s16>) = G_BITCAST [[COPY]](s32) ; CHECK: [[BITCAST:%[0-9]+]]:_(<2 x s16>) = G_BITCAST [[COPY]](s32)
; CHECK: [[BITCAST1:%[0-9]+]]:_(s32) = G_BITCAST [[BITCAST]](<2 x s16>) ; CHECK: $vgpr0 = COPY [[BITCAST]](<2 x s16>)
%0:_(s32) = COPY $vgpr0 %0:_(s32) = COPY $vgpr0
%1:_(<2 x s16>) = G_BITCAST %0 %1:_(<2 x s16>) = G_BITCAST %0
%2:_(s32) = G_BITCAST %1 $vgpr0 = COPY %1
$vgpr0 = COPY %2 ...
---
name: test_bitcast_v2s16_to_s32
body: |
bb.0:
liveins: $vgpr0
; CHECK-LABEL: name: test_bitcast_v2s16_to_s32
; CHECK: [[COPY:%[0-9]+]]:_(<2 x s16>) = COPY $vgpr0
; CHECK: [[BITCAST:%[0-9]+]]:_(s32) = G_BITCAST [[COPY]](<2 x s16>)
; CHECK: $vgpr0 = COPY [[BITCAST]](s32)
%0:_(<2 x s16>) = COPY $vgpr0
%1:_(s32) = G_BITCAST %0
$vgpr0 = COPY %1
...
---
name: test_bitcast_v2s32_to_s64
body: |
bb.0:
liveins: $vgpr0_vgpr1
; CHECK-LABEL: name: test_bitcast_v2s32_to_s64
; CHECK: [[COPY:%[0-9]+]]:_(<2 x s32>) = COPY $vgpr0_vgpr1
; CHECK: [[BITCAST:%[0-9]+]]:_(s64) = G_BITCAST [[COPY]](<2 x s32>)
; CHECK: $vgpr0_vgpr1 = COPY [[BITCAST]](s64)
%0:_(<2 x s32>) = COPY $vgpr0_vgpr1
%1:_(s64) = G_BITCAST %0
$vgpr0_vgpr1 = COPY %1
...
---
name: test_bitcast_s64_to_v2s32
body: |
bb.0:
liveins: $vgpr0_vgpr1
; CHECK-LABEL: name: test_bitcast_s64_to_v2s32
; CHECK: [[COPY:%[0-9]+]]:_(s64) = COPY $vgpr0_vgpr1
; CHECK: [[BITCAST:%[0-9]+]]:_(<2 x s32>) = G_BITCAST [[COPY]](s64)
; CHECK: $vgpr0_vgpr1 = COPY [[BITCAST]](<2 x s32>)
%0:_(s64) = COPY $vgpr0_vgpr1
%1:_(<2 x s32>) = G_BITCAST %0
$vgpr0_vgpr1 = COPY %1
...
---
name: test_bitcast_v2s64_to_v4s32
body: |
bb.0:
liveins: $vgpr0_vgpr1_vgpr2_vgpr3
; CHECK-LABEL: name: test_bitcast_v2s64_to_v4s32
; CHECK: [[COPY:%[0-9]+]]:_(<2 x s64>) = COPY $vgpr0_vgpr1_vgpr2_vgpr3
; CHECK: [[BITCAST:%[0-9]+]]:_(<4 x s32>) = G_BITCAST [[COPY]](<2 x s64>)
; CHECK: $vgpr0_vgpr1_vgpr2_vgpr3 = COPY [[BITCAST]](<4 x s32>)
%0:_(<2 x s64>) = COPY $vgpr0_vgpr1_vgpr2_vgpr3
%1:_(<4 x s32>) = G_BITCAST %0
$vgpr0_vgpr1_vgpr2_vgpr3 = COPY %1
...
---
name: test_bitcast_v4s32_to_v2s64
body: |
bb.0:
liveins: $vgpr0_vgpr1_vgpr2_vgpr3
; CHECK-LABEL: name: test_bitcast_v4s32_to_v2s64
; CHECK: [[COPY:%[0-9]+]]:_(<4 x s32>) = COPY $vgpr0_vgpr1_vgpr2_vgpr3
; CHECK: [[BITCAST:%[0-9]+]]:_(<2 x s64>) = G_BITCAST [[COPY]](<4 x s32>)
; CHECK: $vgpr0_vgpr1_vgpr2_vgpr3 = COPY [[BITCAST]](<2 x s64>)
%0:_(<4 x s32>) = COPY $vgpr0_vgpr1_vgpr2_vgpr3
%1:_(<2 x s64>) = G_BITCAST %0
$vgpr0_vgpr1_vgpr2_vgpr3 = COPY %1
...
---
name: test_bitcast_v4s16_to_s64
body: |
bb.0:
liveins: $vgpr0_vgpr1
; CHECK-LABEL: name: test_bitcast_v4s16_to_s64
; CHECK: [[COPY:%[0-9]+]]:_(<4 x s16>) = COPY $vgpr0_vgpr1
; CHECK: [[BITCAST:%[0-9]+]]:_(s64) = G_BITCAST [[COPY]](<4 x s16>)
; CHECK: $vgpr0_vgpr1 = COPY [[BITCAST]](s64)
%0:_(<4 x s16>) = COPY $vgpr0_vgpr1
%1:_(s64) = G_BITCAST %0
$vgpr0_vgpr1 = COPY %1
...
---
name: test_bitcast_s64_to_v4s16
body: |
bb.0:
liveins: $vgpr0_vgpr1
; CHECK-LABEL: name: test_bitcast_s64_to_v4s16
; CHECK: [[COPY:%[0-9]+]]:_(s64) = COPY $vgpr0_vgpr1
; CHECK: [[BITCAST:%[0-9]+]]:_(<4 x s16>) = G_BITCAST [[COPY]](s64)
; CHECK: $vgpr0_vgpr1 = COPY [[BITCAST]](<4 x s16>)
%0:_(s64) = COPY $vgpr0_vgpr1
%1:_(<4 x s16>) = G_BITCAST %0
$vgpr0_vgpr1 = COPY %1
...
---
name: test_bitcast_p0_to_p1
body: |
bb.0:
liveins: $vgpr0_vgpr1
; CHECK-LABEL: name: test_bitcast_p0_to_p1
; CHECK: [[COPY:%[0-9]+]]:_(p0) = COPY $vgpr0_vgpr1
; CHECK: [[BITCAST:%[0-9]+]]:_(p1) = G_BITCAST [[COPY]](p0)
; CHECK: $vgpr0_vgpr1 = COPY [[BITCAST]](p1)
%0:_(p0) = COPY $vgpr0_vgpr1
%1:_(p1) = G_BITCAST %0
$vgpr0_vgpr1 = COPY %1
...
---
name: test_bitcast_p1_to_p0
body: |
bb.0:
liveins: $vgpr0_vgpr1
; CHECK-LABEL: name: test_bitcast_p1_to_p0
; CHECK: [[COPY:%[0-9]+]]:_(p1) = COPY $vgpr0_vgpr1
; CHECK: [[BITCAST:%[0-9]+]]:_(p0) = G_BITCAST [[COPY]](p1)
; CHECK: $vgpr0_vgpr1 = COPY [[BITCAST]](p0)
%0:_(p1) = COPY $vgpr0_vgpr1
%1:_(p0) = G_BITCAST %0
$vgpr0_vgpr1 = COPY %1
...
---
name: test_bitcast_p999_to_p0
body: |
bb.0:
liveins: $vgpr0_vgpr1
; CHECK-LABEL: name: test_bitcast_p999_to_p0
; CHECK: [[COPY:%[0-9]+]]:_(p999) = COPY $vgpr0_vgpr1
; CHECK: [[BITCAST:%[0-9]+]]:_(p0) = G_BITCAST [[COPY]](p999)
; CHECK: $vgpr0_vgpr1 = COPY [[BITCAST]](p0)
%0:_(p999) = COPY $vgpr0_vgpr1
%1:_(p0) = G_BITCAST %0
$vgpr0_vgpr1 = COPY %1
...
---
name: test_bitcast_p123_to_p999
body: |
bb.0:
liveins: $vgpr0_vgpr1
; CHECK-LABEL: name: test_bitcast_p123_to_p999
; CHECK: [[COPY:%[0-9]+]]:_(p123) = COPY $vgpr0_vgpr1
; CHECK: [[BITCAST:%[0-9]+]]:_(p999) = G_BITCAST [[COPY]](p123)
; CHECK: $vgpr0_vgpr1 = COPY [[BITCAST]](p999)
%0:_(p123) = COPY $vgpr0_vgpr1
%1:_(p999) = G_BITCAST %0
$vgpr0_vgpr1 = COPY %1
... ...