Page MenuHomePhabricator

[NewPM] Add -fsanitize={memory,thread} handling to clang
ClosedPublic

Authored by philip.pfaffe on Jan 17 2019, 1:54 AM.

Diff Detail

Repository
rC Clang

Event Timeline

philip.pfaffe created this revision.Jan 17 2019, 1:54 AM
chandlerc accepted this revision.Jan 17 2019, 1:59 AM

LGTM

clang/lib/CodeGen/BackendUtil.cpp
1016–1017 ↗(On Diff #182222)

Add a FIXME about ASan?

Actually, if you don't mind, could you add code to detect ASan (and any other sanitizers you see in the parallel code) and emit a fatal error and put the FIXME there? I really should have done this to begin with. We should never *ignore* the flag.

Follow-up patch is probably better at that point, and include Richard or Reid on it to make sure its an acceptable way to handle the error.

I don't think we need to produce a full fledged diagnostic here -- this isn't related to the code at all, and this is essentially a "not implemented yet" as opposed to a useful thing for users.

This revision is now accepted and ready to land.Jan 17 2019, 1:59 AM
This revision was automatically updated to reflect the committed changes.