This is an archive of the discontinued LLVM Phabricator instance.

Differential D56801

Fix most of LLVM's tests with LLVM_ENABLE_PIC=OFF
ClosedPublic

Authored by thakis on Jan 16 2019, 12:42 PM.

Details

Reviewers
pcc
Commits
rG43aad9cc328e: Fix most of LLVM's tests with LLVM_ENABLE_PIC=OFF
rL351374: Fix most of LLVM's tests with LLVM_ENABLE_PIC=OFF
Summary

Lots of tests rely on llvm-lto being present, but LLVM_ENABLE_PIC=OFF currently disables building that executable.

There's no reason for not building llvm-lto with LLVM_ENABLE_PIC=OFF so just build it. r191042 moved it into a "if (!WIN)" block at the time, and then 211852 made that "if(NOT CYGWIN AND LLVM_ENABLE_PIC)" -- but that's only needed for LTO (the ld64 plugin), not for the llvm-lto binary.

Diff Detail

Event Timeline

thakis created this revision.Jan 16 2019, 12:42 PM
Herald added subscribers: dexonsmith, mehdi_amini, mgorny. · View Herald TranscriptJan 16 2019, 12:42 PM
pcc accepted this revision.Jan 16 2019, 12:45 PM

LGTM

This revision is now accepted and ready to land.Jan 16 2019, 12:45 PM
Closed by commit rL351374: Fix most of LLVM's tests with LLVM_ENABLE_PIC=OFF (authored by nico). · Explain WhyJan 16 2019, 12:48 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
tools/
1 line

Diff 182123

tools/CMakeLists.txt

Show All 21 Lines
endif() endif()
if(NOT LLVM_USE_INTEL_JITEVENTS ) if(NOT LLVM_USE_INTEL_JITEVENTS )
set(LLVM_TOOL_LLVM_JITLISTENER_BUILD Off) set(LLVM_TOOL_LLVM_JITLISTENER_BUILD Off)
endif() endif()
if(CYGWIN OR NOT LLVM_ENABLE_PIC) if(CYGWIN OR NOT LLVM_ENABLE_PIC)
set(LLVM_TOOL_LTO_BUILD Off) set(LLVM_TOOL_LTO_BUILD Off)
set(LLVM_TOOL_LLVM_LTO_BUILD Off)
endif() endif()
# Add LTO, llvm-ar, llvm-config, and llvm-profdata before clang, ExternalProject # Add LTO, llvm-ar, llvm-config, and llvm-profdata before clang, ExternalProject
# requires targets specified in DEPENDS to exist before the call to # requires targets specified in DEPENDS to exist before the call to
# ExternalProject_Add. # ExternalProject_Add.
add_llvm_tool_subdirectory(lto) add_llvm_tool_subdirectory(lto)
add_llvm_tool_subdirectory(gold) add_llvm_tool_subdirectory(gold)
add_llvm_tool_subdirectory(llvm-ar) add_llvm_tool_subdirectory(llvm-ar)
Show All 21 Lines