This is an archive of the discontinued LLVM Phabricator instance.

Fix most of LLVM's tests with LLVM_ENABLE_PIC=OFF
ClosedPublic

Authored by thakis on Jan 16 2019, 12:42 PM.

Details

Summary

Lots of tests rely on llvm-lto being present, but LLVM_ENABLE_PIC=OFF currently disables building that executable.

There's no reason for not building llvm-lto with LLVM_ENABLE_PIC=OFF so just build it. r191042 moved it into a "if (!WIN)" block at the time, and then 211852 made that "if(NOT CYGWIN AND LLVM_ENABLE_PIC)" -- but that's only needed for LTO (the ld64 plugin), not for the llvm-lto binary.

Diff Detail

Repository
rL LLVM

Event Timeline

thakis created this revision.Jan 16 2019, 12:42 PM
pcc accepted this revision.Jan 16 2019, 12:45 PM

LGTM

This revision is now accepted and ready to land.Jan 16 2019, 12:45 PM
This revision was automatically updated to reflect the committed changes.