Sometimes the SLP vectorizer tries to vectorize the horizontal reduction
nodes during regular vectorization. This may happen inside of the loops,
when there are some vectorizable PHIs. Patch fixes this by checking if
the node is the reduction node and thus it must not be vectorized, it must
be gathered.
Details
Details
- Reviewers
RKSimon spatel hfinkel fedor.sergeev - Commits
- rG2b727e7e3619: Merging r351349: --------------------------------------------------------------…
rG18809a6bbbc7: [SLP] Fix PR40310: The reduction nodes should stay scalar.
rL351440: Merging r351349:
rL351349: [SLP] Fix PR40310: The reduction nodes should stay scalar.
Diff Detail
Diff Detail
- Repository
- rL LLVM
- Build Status
Buildable 26907 Build 26906: arc lint + arc unit
Event Timeline
Comment Actions
Looks good.
Thanks for a taking care of this!
As I already mentioned in PR40310, this fix passes all my local tests which were failing with horizontal reduction.