This is an archive of the discontinued LLVM Phabricator instance.

[llvm-objdump] - Simplify the getRelocationValueString. NFCI.
ClosedPublic

Authored by grimar on Jan 16 2019, 5:08 AM.

Details

Summary

This refactors the getRelocationValueString method.
It is a bit overcomplicated and it is possible to reduce it without
losing the functionality it seems.

Diff Detail

Event Timeline

grimar created this revision.Jan 16 2019, 5:08 AM
jhenderson accepted this revision.Jan 16 2019, 5:38 AM

LGTM, with one nit.

tools/llvm-objdump/llvm-objdump.cpp
501

Delete the "atm".

This revision is now accepted and ready to land.Jan 16 2019, 5:38 AM
This revision was automatically updated to reflect the committed changes.