Page MenuHomePhabricator

handle invokes like calls for sample profile data
Needs ReviewPublic

Authored by david2050 on Jan 15 2019, 5:22 PM.

Details

Summary

Dropping the names of invokes will lead to loss
of information possibly leading to inlining of
cold calls unnecessarily.

Diff Detail

Event Timeline

david2050 created this revision.Jan 15 2019, 5:22 PM
vsk added a subscriber: vsk.Jan 16 2019, 12:17 PM
vsk added inline comments.
lib/Transforms/IPO/SampleProfile.cpp
664

CallSite(&Inst).getCalledFunction() might be easier to read here.

david2050 updated this revision to Diff 182157.Jan 16 2019, 2:47 PM

apply suggestion from @vsk

vsk added a comment.Jan 16 2019, 2:50 PM

(Looks reasonable to me. I haven't really touched this code, so it'd help if another review could +1 the change.)