This is an archive of the discontinued LLVM Phabricator instance.

[ASTDump] Mark BlockDecls which capture this with a tag
ClosedPublic

Authored by steveire on Jan 15 2019, 3:39 PM.

Reviewers

Commits

Summary

Removal of the child node makes it easier to separate traversal from
output generation.

Repository

rC Clang

Build Status

Buildable 26880
Build 26879: arc lint + arc unit

Update

Was there no test coverage for this situation? If not, can you add some?

Rebase

LGTM!

This revision is now accepted and ready to land.Jan 18 2019, 5:45 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

lib/

AST/

6 lines

Show First 20 Lines • Show All 1,373 Lines • ▼ Show 20 Lines	if (C.hasCopyExpr())
dumpStmt(C.getCopyExpr());		dumpStmt(C.getCopyExpr());
});		});
}		}

void ASTDumper::VisitBlockDecl(const BlockDecl *D) {		void ASTDumper::VisitBlockDecl(const BlockDecl *D) {
if (D->isVariadic())		if (D->isVariadic())
OS << " variadic";		OS << " variadic";

		if (D->capturesCXXThis())
		OS << "captures_this";

for (auto I : D->parameters())		for (auto I : D->parameters())
dumpDecl(I);		dumpDecl(I);

if (D->capturesCXXThis())
dumpChild([=]{ OS << "capture this"; });

for (const auto &I : D->captures())		for (const auto &I : D->captures())
Visit(I);		Visit(I);
dumpStmt(D->getBody());		dumpStmt(D->getBody());
}		}

//===----------------------------------------------------------------------===//		//===----------------------------------------------------------------------===//
// Stmt dumping methods.		// Stmt dumping methods.
//===----------------------------------------------------------------------===//		//===----------------------------------------------------------------------===//
▲ Show 20 Lines • Show All 263 Lines • Show Last 20 Lines