Diff Detail
Diff Detail
Event Timeline
Comment Actions
Looks reasonable :)
clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountChecker.h | ||
---|---|---|
263–265 | Why not simply make it a field? I.e., why do we need a unique_ptr / heap allocation here? Do we need to transfer ownership? | |
clang/lib/StaticAnalyzer/Core/RetainSummaryManager.cpp | ||
191 | I think you should try QT->getPointeeCXXRecordDecl(). | |
253 | You mean something like "inverted"? I.e., flipped rather than un-done? | |
294 | I think it's not a great place for auto. |
Why not simply make it a field? I.e., why do we need a unique_ptr / heap allocation here? Do we need to transfer ownership?