Page MenuHomePhabricator

[analyzer] [RetainCountChecker] Introduce optional tracking of unannotated retain out parameters, behind a flag
AbandonedPublic

Authored by george.karpenkov on Jan 15 2019, 11:49 AM.

Details

Reviewers
dcoughlin
NoQ

Diff Detail

Event Timeline

NoQ accepted this revision.Jan 15 2019, 4:44 PM

Looks reasonable :)

clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountChecker.h
263–265

Why not simply make it a field? I.e., why do we need a unique_ptr / heap allocation here? Do we need to transfer ownership?

clang/lib/StaticAnalyzer/Core/RetainSummaryManager.cpp
191

I think you should try QT->getPointeeCXXRecordDecl().

253

You mean something like "inverted"? I.e., flipped rather than un-done?

294

I think it's not a great place for auto.

This revision is now accepted and ready to land.Jan 15 2019, 4:44 PM
george.karpenkov abandoned this revision.Nov 20 2019, 5:55 PM