[Tsan] Make the user_fopen.cc and user_malloc.cc tests Linux-specific

[kutuzov.viktor.84]

Summary

Since on FreeBSD interceptors are non-weak symbols, it doesn't seem to be possible to override them.

Related revision: D4418.

[glider]

LGTM

test/tsan/Linux/user_fopen.cc

5

s/defined/Defined

test/tsan/Linux/user_malloc.cc

4

pls change s/defined/Defined while you're at it.

[samsonov]

test/tsan/Linux/lit.local.cfg

10

Why override the parent directory's decision? We can mark tests as unsupported there for various reasons. IMO you should just use

if root.host_os not in ['Linux']:
  config.unsupported = True

[kutuzov.viktor.84]

The config reworked and comments fixed as suggested.

[samsonov]

LGTM

Closed by commit rL219478 (authored by vkutuzov).

[kutuzov.viktor.84]

The comments fixed in rL219481.

test/tsan/Linux/lit.local.cfg

+def getRoot(config):
+  if not config.parent:
+    return config
+  return getRoot(config.parent)
+
+root = getRoot(config)
+
+# Override the parent directory's "unsupported" decision until we can handle
+# all of its tests.
+if root.host_os in ['Linux']:
+  config.unsupported = False
+else:
+  config.unsupported = True

test/tsan/Linux/user_fopen.cc

+// RUN: %clangxx_tsan -O1 %s -o %t && %run %t 2>&1 | FileCheck %s
+#include <stdio.h>
+#include <stdlib.h>
+
+// defined by tsan.
+extern "C" FILE *__interceptor_fopen(const char *file, const char *mode);
+extern "C" int __interceptor_fileno(FILE *f);
+
+extern "C" FILE *fopen(const char *file, const char *mode) {
+  static int first = 0;
+  if (__sync_lock_test_and_set(&first, 1) == 0)
+    printf("user fopen\n");
+  return __interceptor_fopen(file, mode);
+}
+
+extern "C" int fileno(FILE *f) {
+  static int first = 0;
+  if (__sync_lock_test_and_set(&first, 1) == 0)
+    printf("user fileno\n");
+  return 1;
+}
+
+int main() {
+  FILE *f = fopen("/dev/zero", "r");
+  if (f) {
+    char buf;
+    fread(&buf, 1, 1, f);
+    fclose(f);
+  }
+}
+
+// CHECK: user fopen
+// CHECK-NOT: ThreadSanitizer
+

test/tsan/Linux/user_malloc.cc

+// RUN: %clangxx_tsan -O1 %s -o %t && %run %t 2>&1 | FileCheck %s
+#include <stdio.h>
+
+// defined by tsan.
+extern "C" void *__interceptor_malloc(unsigned long size);
+extern "C" void __interceptor_free(void *p);
+
+extern "C" void *malloc(unsigned long size) {
+  static int first = 0;
+  if (__sync_lock_test_and_set(&first, 1) == 0)
+    printf("user malloc\n");
+  return __interceptor_malloc(size);
+}
+
+extern "C" void free(void *p) {
+  __interceptor_free(p);
+}
+
+int main() {
+  volatile char *p = (char*)malloc(10);
+  p[0] = 0;
+  free((void*)p);
+}
+
+// CHECK: user malloc
+// CHECK-NOT: ThreadSanitizer
+

test/tsan/user_fopen.cc

-// RUN: %clangxx_tsan -O1 %s -o %t && %run %t 2>&1 | FileCheck %s
-#include <stdio.h>
-#include <stdlib.h>
-
-// defined by tsan.
-extern "C" FILE *__interceptor_fopen(const char *file, const char *mode);
-extern "C" int __interceptor_fileno(FILE *f);
-
-extern "C" FILE *fopen(const char *file, const char *mode) {
-  static int first = 0;
-  if (__sync_lock_test_and_set(&first, 1) == 0)
-    printf("user fopen\n");
-  return __interceptor_fopen(file, mode);
-}
-
-extern "C" int fileno(FILE *f) {
-  static int first = 0;
-  if (__sync_lock_test_and_set(&first, 1) == 0)
-    printf("user fileno\n");
-  return 1;
-}
-
-int main() {
-  FILE *f = fopen("/dev/zero", "r");
-  if (f) {
-    char buf;
-    fread(&buf, 1, 1, f);
-    fclose(f);
-  }
-}
-
-// CHECK: user fopen
-// CHECK-NOT: ThreadSanitizer
-

test/tsan/user_malloc.cc

-// RUN: %clangxx_tsan -O1 %s -o %t && %run %t 2>&1 | FileCheck %s
-#include <stdio.h>
-
-// defined by tsan.
-extern "C" void *__interceptor_malloc(unsigned long size);
-extern "C" void __interceptor_free(void *p);
-
-extern "C" void *malloc(unsigned long size) {
-  static int first = 0;
-  if (__sync_lock_test_and_set(&first, 1) == 0)
-    printf("user malloc\n");
-  return __interceptor_malloc(size);
-}
-
-extern "C" void free(void *p) {
-  __interceptor_free(p);
-}
-
-int main() {
-  volatile char *p = (char*)malloc(10);
-  p[0] = 0;
-  free((void*)p);
-}
-
-// CHECK: user malloc
-// CHECK-NOT: ThreadSanitizer
-