Page MenuHomePhabricator

Remove NameLen argument from newly-introduced IR C APIs.
ClosedPublic

Authored by jyknight on Jan 14 2019, 9:15 AM.

Details

Summary

Normally, changing the function signatures of C APIs is disallowed,
but as these two are brand new last week, and haven't been released
yet, it is okay in this instance.

As per discussion in D56556, we will not add NameLen arguments to IR
building APIs, for the following reasons:

  1. We do not want to deprecate all of the IR building APIs, just to add a

NameLen argument to each one.

  1. Consistency is important, so adding it just to new ones is unfortunate.
  1. The IR names are completely optional, useful for readability of IR

only. There is no value in ever supporting nul bytes.

Diff Detail

Repository
rL LLVM

Event Timeline

jyknight created this revision.Jan 14 2019, 9:15 AM
jyknight updated this revision to Diff 181569.Jan 14 2019, 9:17 AM

(Ugh, forgot to cc llvm-commits)

Harbormaster completed remote builds in B26795: Diff 181569.
whitequark accepted this revision.Jan 14 2019, 9:18 AM
This revision is now accepted and ready to land.Jan 14 2019, 9:18 AM
This revision was automatically updated to reflect the committed changes.