This is an archive of the discontinued LLVM Phabricator instance.

Differential D56667

Explicitly set C++ standard for `Posix/no-fd.cc` ASan test.
ClosedPublic

Authored by delcypher on Jan 14 2019, 8:02 AM.

Details

Reviewers
eugenis
yln
vitalybuka
Commits
rGcf34faa3e588: Explicitly set C++ standard for `Posix/no-fd.cc` ASan test.
rCRT351169: Explicitly set C++ standard for `Posix/no-fd.cc` ASan test.
rL351169: Explicitly set C++ standard for `Posix/no-fd.cc` ASan test.
Summary

The test uses nullptr which can break running the test if the
compiler happens to be using something older than C++11 as the default
language standard. Avoid this by explicitly setting the standard.

rdar://problem/47253542

Diff Detail

Repository
rL LLVM

Event Timeline

delcypher created this revision.Jan 14 2019, 8:02 AM
Herald added subscribers: Restricted Project, kubamracek. · View Herald TranscriptJan 14 2019, 8:02 AM
Harbormaster completed remote builds in B26790: Diff 181561.Jan 14 2019, 8:04 AM
delcypher edited the summary of this revision. (Show Details)Jan 14 2019, 8:39 AM
eugenis accepted this revision.Jan 14 2019, 3:21 PM

LGTM

This revision is now accepted and ready to land.Jan 14 2019, 3:21 PM
delcypher retitled this revision from Explicitly set C++ standard fo `Posix/no-fd.cc` ASan test. to Explicitly set C++ standard for `Posix/no-fd.cc` ASan test..Jan 15 2019, 12:56 AM
Closed by commit rL351169: Explicitly set C++ standard for `Posix/no-fd.cc` ASan test. (authored by delcypher). · Explain WhyJan 15 2019, 12:58 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
compiler-rt/
trunk/
test/
asan/
TestCases/
Posix/
2 lines

Diff 181734

compiler-rt/trunk/test/asan/TestCases/Posix/no-fd.cc

// RUN: %clangxx_asan -O0 %s -o %t // RUN: %clangxx_asan -std=c++11 -O0 %s -o %t
// RUN: %run %t 2>&1 | FileCheck %s // RUN: %run %t 2>&1 | FileCheck %s
// RUN: %env_asan_opts=debug=1,verbosity=2 %run %t 2>&1 | FileCheck %s // RUN: %env_asan_opts=debug=1,verbosity=2 %run %t 2>&1 | FileCheck %s
// Test ASan initialization // Test ASan initialization
#include <assert.h> #include <assert.h>
#include <stdio.h> #include <stdio.h>
#include <stdlib.h> #include <stdlib.h>
Show All 34 Lines