This is an archive of the discontinued LLVM Phabricator instance.

Differential D5665

[Tsan] Fix the blacklist2.cc test to pass on FreeBSD
ClosedPublic

Authored by kutuzov.viktor.84 on Oct 8 2014, 4:50 AM.

Details

Reviewers
kcc
glider
samsonov
Commits
rCRT219397: [Tsan] Fix the blacklist2.cc test to pass on FreeBSD
rL219397: [Tsan] Fix the blacklist2.cc test to pass on FreeBSD
Summary

TouchGlobal() verbalizes as TouchGlobal(void) on FreeBSD.

Diff Detail

Repository
rL LLVM

Event Timeline

kutuzov.viktor.84 updated this revision to Diff 14559.Oct 8 2014, 4:50 AM
kutuzov.viktor.84 retitled this revision from to [Tsan] Fix the blacklist2.cc test to pass on FreeBSD.
kutuzov.viktor.84 updated this object.
kutuzov.viktor.84 edited the test plan for this revision. (Show Details)
kutuzov.viktor.84 added reviewers: kcc, samsonov.
kutuzov.viktor.84 added a reviewer: glider.
kutuzov.viktor.84 added subscribers: Unknown Object (MLST), emaste.
samsonov accepted this revision.Oct 8 2014, 1:49 PM
samsonov edited edge metadata.

LGTM

This revision is now accepted and ready to land.Oct 8 2014, 1:49 PM
Diffusion closed this revision.Oct 9 2014, 2:14 AM
Diffusion updated this revision to Diff 14638.

Closed by commit rL219397 (authored by vkutuzov).

Revision Contents

PathSize
compiler-rt/
trunk/
test/
tsan/
2 lines

Diff 14638

compiler-rt/trunk/test/tsan/blacklist2.cc

Show All 16 Linesvoid *Thread1(void *x) {
// CHECK: Write of size 4 // CHECK: Write of size 4
// CHECK: #0 Thread1{{.*}}blacklist2.cc:[[@LINE+1]] // CHECK: #0 Thread1{{.*}}blacklist2.cc:[[@LINE+1]]
Global++; Global++;
return NULL; return NULL;
} }
void TouchGlobal() { void TouchGlobal() {
// CHECK: Previous write of size 4 // CHECK: Previous write of size 4
// CHECK: #0 TouchGlobal(){{.*}}blacklist2.cc:[[@LINE+1]] // CHECK: #0 TouchGlobal{{.*}}blacklist2.cc:[[@LINE+1]]
Global--; Global--;
} }
void CallTouchGlobal() { void CallTouchGlobal() {
// CHECK: #1 CallTouchGlobal{{.*}}blacklist2.cc:[[@LINE+1]] // CHECK: #1 CallTouchGlobal{{.*}}blacklist2.cc:[[@LINE+1]]
TouchGlobal(); TouchGlobal();
} }
Show All 16 Lines